Add special case in _get_tune_resources
#250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
Yard1
changed the title
_get_tune_resources
krfricke
approved these changes
Dec 8, 2022
Yard1
changed the title
_get_tune_resources_get_tune_resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antoni Baum antoni.baum@protonmail.com
If
_max_cpu_fraction_per_nodeis None and passed toplacement_group, an exception will be thrown. Currently, code in Ray doesn't discard that key if its None before passing it toxgboost_ray.RayParams. This will be fixed properly in Ray (ray-project/ray#30977), but in the meantime, we add a special case here to ensure that Ray 2.2 works.