use for loop instead of map for possible memory use reduction

ray1729 · Dec 29, 2009 · c2ae857 · c2ae857
1 parent 60145e6
commit c2ae857
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib/Plack/Middleware.pm b/lib/Plack/Middleware.pm
@@ -33,10 +33,12 @@ sub response_cb {
         if (defined $filter_cb && ref $filter_cb eq 'CODE') {
             Plack::Util::header_remove($res->[1], 'Content-Length');
             if (defined $res->[2]) {
-                my $body    = $res->[2];
-                if (ref $body eq 'ARRAY') {
-                    $res->[2] = [ map $filter_cb->($_), @$body ];
+                if (ref $res->[2] eq 'ARRAY') {
+                    for my $line (@{$res->[2]}) {
+                        $line = $filter_cb->($line);
+                    }
                 } else {
+                    my $body    = $res->[2];
                     my $getline = sub { $body->getline };
                     $res->[2] = Plack::Util::inline_object
                         getline => sub { $filter_cb->($getline->()) },

diff --git a/t/Plack-Middleware/simple_content_filter.t b/t/Plack-Middleware/simple_content_filter.t
@@ -4,7 +4,7 @@ use Plack::Test;
 use Plack::Builder;
 
 my $app = sub {
-    return [ 200, [ 'Content-Type' => 'text/plain', 'Content-Length' => 9 ], [ 'Hello Foo' ] ];
+    return [ 200, [ 'Content-Type' => 'text/plain', 'Content-Length' => 9 ], [ 'Hello ', 'Foo' ] ];
 };
 
 $app = builder {