Merge pull request xarray-contrib#111 from bradyrx/fix_read_only

raybellwaves · Jul 10, 2020 · 6d463c5 · 6d463c5
2 parents 8378ba9 + a37ed51
commit 6d463c5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -14,6 +14,12 @@ Internal Changes
 - Add ``black``, ``flake8``, ``isort``, ``doc8`` and ``pre-commit`` for formatting
   similar to ``climpred``. `Aaron Spring`_ and `Ray Bell`_
 
+Bug Fixes
+---------
+- Avoid mutating inputted arrays when `skipna=True`. (:pr:`111`) `Riley X. Brady`_.
+- Avoid read-only error that appeared due to not copying input arrays when dealing
+  with NaNs. (:pr:`111`) `Riley X. Brady`_.
+
 
 xskillscore v0.0.15 (2020-03-24)
 ================================

diff --git a/xskillscore/core/np_deterministic.py b/xskillscore/core/np_deterministic.py
@@ -32,6 +32,8 @@ def _match_nans(a, b, weights):
         pairwise locations.
     """
     if np.isnan(a).any() or np.isnan(b).any():
+        # Avoids mutating original arrays and bypasses read-only issue.
+        a, b = a.copy(), b.copy()
         # Find pairwise indices in a and b that have nans.
         idx = np.logical_or(np.isnan(a), np.isnan(b))
         a[idx], b[idx] = np.nan, np.nan