[GitHub -> Notifications] Distinct visually read and unread notifications

[teziovsky]

Extension

https://www.raycast.com/raycast/github

Description

It would be great to visually distinguish the read and unread notifications. At the moment there is a list section with read and unread, but it could be more visible. You know, quick look and you know what is what right away.

Some examples:

• the colors of icons could be different, like orange for unread, and green for read,
• the text of the read notification could be gray, and the unread notification could be white

Who will benefit from this feature?

No response

Anything else?

No response

[raycastbot]

Thank you for opening this issue!

🔔 @thomaslombart @unnamedd @tonka3000 @khasbilegt @pernielsentikaer @loxygenK @oilbeater @LunaticMuch @aeorge @daquinoaldo @peppy @aeither @marcotf @qeude @nesl247 you might want to have a look.

💡 Author and Contributors commands

The author and contributors of raycast/github can trigger bot actions by commenting:

• @raycastbot close this issue Closes the issue.
• @raycastbot rename this issue to "Awesome new title" Renames the issue.
• @raycastbot reopen this issue Reopen the issue.

[thomaslombart]

Good idea! Do you want to actually look at it?

[teziovsky]

I'm confident in my ability to enhance it, but I'd like your input on which example you find more preferable 🤔 Alternatively if you have any other suggestions for resolving this, I'm open to hearing them 🤔

[thomaslombart]

I think I'll go for shades of gray here as orange and green may be too distracting.

[teziovsky]

I think it's not possible to implement. I mean shades of gray in List.Item title. The title could only get value and tooltip props 🤔

[teziovsky]

What do you think about those examples:

[xilopaint]

I think this would create immense confusion. The colors of these icons on GitHub UI reflect the statuses of issues and PRs: issues can be open, closed, or not planned (green, purple, and gray), and PRs can be open, closed, or merged (green, red, and purple).

Anything different from this pattern would be counterintuitive and a big mistake.

Also, the Unread and Read sections already clearly communicate the status of the notifications.

The key question is whether we should color the icons according to the correct GitHub pattern. In my view, yes, we should. This way, if I have a purple PR icon in the Unread section, I know that I'm being notified about a merged PR. This adds real information to the UI.

[teziovsky]

I think this would create immense confusion. The colors of these icons on GitHub UI reflect the statuses of issues and PRs: issues can be open, closed, or not planned (green, purple, and gray), and PRs can be open, closed, or merged (green, red, and purple).

Anything different from this pattern would be counterintuitive and a big mistake.

Also, the Unread and Read sections already clearly communicate the status of the notifications.

The key question is whether we should color the icons according to the correct GitHub pattern. In my view, yes, we should. This way, if I have a purple PR icon in the Unread section, I know that I'm being notified about a merged PR. This adds real information to the UI.

Agree with that.

[thomaslombart]

Yeah, I meant using Color.SecondaryText for the read section as the gray color is less visible like below:

But applying the actual colors as done on GitHub's UI is a great idea as well. I'm fine with both. 🙂

[raycastbot]

This issue has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 10 days to keep our backlog clean 😊

[xilopaint]

@thomaslombart @pernielsentikaer I think this PR can be closed as #11653 has been merged and the OP agrees with the solution.