Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub] Show notification bar in GitHub UI when opening a notification in browser #11751

Open
tom-sherman opened this issue Apr 11, 2024 · 9 comments
Labels
extension: github Issues related to the github extension extension Issues related to one of the extensions in the Store feature request New feature or improvement status: stalled Stalled due inactivity

Comments

@tom-sherman
Copy link

Extension

https://www.raycast.com/raycast/github

Description

It would be great if when I open a notification from the menubar or command in my browser that I get the same experience as when navigating from the GitHub web notification list

image

Who will benefit from this feature?

Will allow me to easily organise notifications by eg. marking them as done.

Anything else?

No response

@tom-sherman tom-sherman added extension Issues related to one of the extensions in the Store feature request New feature or improvement labels Apr 11, 2024
@raycastbot raycastbot added the extension: github Issues related to the github extension label Apr 11, 2024
@raycastbot
Copy link
Collaborator

Thank you for opening this issue!

🔔 @thomaslombart @unnamedd @tonka3000 @khasbilegt @pernielsentikaer @loxygenK @oilbeater @LunaticMuch @aeorge @daquinoaldo @peppy @aeither @marcotf @qeude @nesl247 @xilopaint @antonengelhardt @bangerang you might want to have a look.

💡 Author and Contributors commands

The author and contributors of raycast/github can trigger bot actions by commenting:

  • @raycastbot close this issue Closes the issue.
  • @raycastbot rename this issue to "Awesome new title" Renames the issue.
  • @raycastbot reopen this issue Reopen the issue.

@antonengelhardt
Copy link
Contributor

antonengelhardt commented Apr 11, 2024

I noticed that too, but the issue is that, we show all notifications (grouped by read/unread) including done notifications instead of only "undone" ones:

const {
    data,
    isLoading,
    mutate: mutateList,
  } = useCachedPromise(async () => {
    const response = await octokit.rest.activity.listNotificationsForAuthenticatedUser({ all: true });
    return response.data;
  });

If you can change that to all: false, then only unread notifications show up and not "undone" notifications.

But generally i am in favor of showing only undone notifications and then sort them by read/unread.

@tom-sherman
Copy link
Author

When I navigate to a done notification from the GitHub UI I also get a banner, could a navigation from Raycast match this behaviour?

image

Like you though, I personally have no need for seeing done notifications in Raycast.

@thomaslombart
Copy link
Collaborator

It won't be possible to show a navigation banner like GitHub's UI. However, we can certainly add more actions in the Action Panel like the Unsubscribe one (so we'd need to probably call this endpoint). Not sure about the Save action as I didn't found anything in the GitHub's API.

@antonengelhardt
Copy link
Contributor

Unsubscribe is already there:

Screenshot-CleanShot-006600@2x

I think it would be very useful, if the Github extension actually replicated the grouping of the GitHub Web UI, meaning that we group by unread/read/done. Currently, i see all notifications in my extension. I tick them off in the web ui and also in GH mobile app. But they still appear in the Read Section in the extension... What do you think?

@antonengelhardt
Copy link
Contributor

Unsure if this even possible, as the notification object doesn't include any info if its done or not. Same for the endpoint listNotificationsForAuthenticatedUser(), which has the filter, but it only filters away read notifications. Hmm

@thomaslombart
Copy link
Collaborator

Oh yeah, true. I didn't even remember I added it 😄

Unfortunately, the GitHub notifications API is limited so not sure we can do something here…

@antonengelhardt
Copy link
Contributor

lets see :)

@raycastbot
Copy link
Collaborator

This issue has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 10 days to keep our backlog clean 😊

@raycastbot raycastbot added the status: stalled Stalled due inactivity label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension: github Issues related to the github extension extension Issues related to one of the extensions in the Store feature request New feature or improvement status: stalled Stalled due inactivity
Projects
None yet
Development

No branches or pull requests

4 participants