Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API Bug] Icons from a local file resource do not render in ActionPanel.Submenu Items #28

Closed
moored opened this issue Oct 14, 2021 · 1 comment
Assignees
Labels
api Issues related to API bug Something isn't working status: fixed in next release The issue will be closed once next release is available

Comments

@moored
Copy link
Contributor

moored commented Oct 14, 2021

Raycast version: 1.25.0

Description

If an icon from a local file resource is added to an ActionPanel Submenu Item it does not render

Steps To Reproduce

  1. Edit actions.tsx in examples/api-examples/src
  2. Add icon={{ source: { dark: "avatar-dark.png", light: "avatar-light.png" } }} after line 67

The current behavior

Icon does not render; if you change it to a built-in Icon it will. Eg. icon={Icon.Binoculars}

The expected behavior

Icon to render.

@moored moored added api Issues related to API bug Something isn't working labels Oct 14, 2021
@moored moored changed the title Icons from a local file resource do not render in ActionPanel.Submenu Items [API Bug] Icons from a local file resource do not render in ActionPanel.Submenu Items Oct 14, 2021
@mattisssa mattisssa self-assigned this Oct 14, 2021
@mattisssa
Copy link
Contributor

Good catch! Thanks, will be fixed soon

@mattisssa mattisssa added the status: fixed in next release The issue will be closed once next release is available label Oct 18, 2021
sejas added a commit to sejas/raycast-extensions that referenced this issue Dec 6, 2023
- Update list of commands screenshot on Readme
- Hosting Command Palette: Prepare metadata and screenshots for submission to the store (raycast#38)
- Fix commands title case to make the linter happier
- Hosting Command Palette: Use extension name as ref for new URLs (raycast#37)
- Fixes grammar error in the description and subtitle of the command (raycast#34)
- Fixes project title to use the right capitalization (raycast#36)
- Hosting Command Palette: Add cache action commands on Raycast (raycast#31)
- Hosting Command Palette: Add more site management commands (raycast#29)
- Hosting Command Palette: Add keywords for each command (raycast#28)
- Hosting Command Palette: Add \'Open Jetpack Scan\' and \'Open Jetpack Social\' (raycast#26)
- Hosting Command Palette: Use Jetpack Cloud for Activity and Backup (raycast#24)
- Hosting Command Palette: Fix command description at root (raycast#32)
- Fix linting issue
- Hosting Command Palette: After selecting a command that opens a web page, the list of sites is empty (raycast#22)
- Hosting Command Palette: Add \'Open Reader\' command (raycast#23)
- Fix linting failure (raycast#25)
- Hosting Command Palette: Add \'View media uploads\' command to Raycast (raycast#20)
- Hosting command Palette: Add url to label (raycast#21)
- Hosting Command Palette: Switch oAuth provider back to \'WordPress.com\' (raycast#19)
- Hosting Command Palette: Change the package.json author  (raycast#13)
- Hosting Command Palette: Fix site item styling (raycast#9)
- Hosting Command Palette: Tweak oAuth connection strings (raycast#17)
- Hosting Command Palette: Fix JP product name (raycast#18)
- Hosting Command Palette: Register additional site management commands for Raycast (raycast#15)
- Add a PULL_REQUEST_TEMPLATE (raycast#14)
- Hosting Command Palette: Apply WordPress.com branding to WordPress.com-specific commands (raycast#12)
- Hosting Command Paltte: Fix lint errors (raycast#11)
- Hosting Command Palette: Navigate to root after site command (raycast#8)
- Hosting Command Pallette: Add navigational commands (raycast#7)
- Hosting Command Palette: Add ssh commands (raycast#5)
- Hosting Command Palette: Add OAuth support (raycast#3)
- Hosting Command Palette: Add running locally docs (raycast#4)
- Hosting Command Pallete: Update the name of the extension (raycast#2)
- Prototype: minor refactor (raycast#1)
- Initial commit using the code from Raycast exploration
- Initial commit
raycastbot added a commit that referenced this issue Dec 13, 2023
* Add jetpack-commands extension

- Update list of commands screenshot on Readme
- Hosting Command Palette: Prepare metadata and screenshots for submission to the store (#38)
- Fix commands title case to make the linter happier
- Hosting Command Palette: Use extension name as ref for new URLs (#37)
- Fixes grammar error in the description and subtitle of the command (#34)
- Fixes project title to use the right capitalization (#36)
- Hosting Command Palette: Add cache action commands on Raycast (#31)
- Hosting Command Palette: Add more site management commands (#29)
- Hosting Command Palette: Add keywords for each command (#28)
- Hosting Command Palette: Add \'Open Jetpack Scan\' and \'Open Jetpack Social\' (#26)
- Hosting Command Palette: Use Jetpack Cloud for Activity and Backup (#24)
- Hosting Command Palette: Fix command description at root (#32)
- Fix linting issue
- Hosting Command Palette: After selecting a command that opens a web page, the list of sites is empty (#22)
- Hosting Command Palette: Add \'Open Reader\' command (#23)
- Fix linting failure (#25)
- Hosting Command Palette: Add \'View media uploads\' command to Raycast (#20)
- Hosting command Palette: Add url to label (#21)
- Hosting Command Palette: Switch oAuth provider back to \'WordPress.com\' (#19)
- Hosting Command Palette: Change the package.json author  (#13)
- Hosting Command Palette: Fix site item styling (#9)
- Hosting Command Palette: Tweak oAuth connection strings (#17)
- Hosting Command Palette: Fix JP product name (#18)
- Hosting Command Palette: Register additional site management commands for Raycast (#15)
- Add a PULL_REQUEST_TEMPLATE (#14)
- Hosting Command Palette: Apply WordPress.com branding to WordPress.com-specific commands (#12)
- Hosting Command Paltte: Fix lint errors (#11)
- Hosting Command Palette: Navigate to root after site command (#8)
- Hosting Command Pallette: Add navigational commands (#7)
- Hosting Command Palette: Add ssh commands (#5)
- Hosting Command Palette: Add OAuth support (#3)
- Hosting Command Palette: Add running locally docs (#4)
- Hosting Command Pallete: Update the name of the extension (#2)
- Prototype: minor refactor (#1)
- Initial commit using the code from Raycast exploration
- Initial commit

* Using images from metadata

* Update package.json

* Update CHANGELOG.md and optimise images

---------

Co-authored-by: Per Nielsen Tikær <per@raycast.com>
Co-authored-by: raycastbot <bot@raycast.com>
thuoe added a commit to thuoe/raycast-extensions that referenced this issue Jan 10, 2024
- Merge pull request raycast#29 from thuoe/next
- Merge pull request raycast#28 from thuoe/feature/thu-34-error-handling-faulty-api-tokens
- fix: handle errors across views
- refactor: hooks response types
- fix: handle hook data responses if invalid token is found
- fix: provide error from promise hook
- feat: create error toast hook
- Merge pull request raycast#27 from thuoe/main
raycastbot added a commit that referenced this issue Jan 12, 2024
* Add footy-report extension

- Merge pull request #22 from thuoe/next
- Merge pull request #21 from thuoe/docs/2023-12-26-changelog
- docs: update changelog
- Merge pull request #20 from thuoe/feature/thu-33-redesign-test-api-command
- docs: update screenshots
- chore: delete unused assets
- feat: action to open ext preferences
- feat: use form to test API access token
- Merge pull request #19 from thuoe/bugfix/fetch-teams
- fix: optional position name
- Merge pull request #2 from thuoe/feature/thu-15-raycast-create-search-command
- Merge pull request #10 from thuoe/feature/thu-26-create-command-screenshots
- docs: include command screenshots in README.md
- docs: player stats screenshot
- docs: team list screenshot
- docs: update team details & API screenshots
- docs: delete outdated screenshots
- docs: create command screenshots
- Merge pull request #17 from thuoe/bugfix/type-errors
- build: include build step during CI pipeline
- fix: type error fetch teams hook
- fix: type error command arg
- fix: type errors for fetching fixtures
- fix: type erros from player stats
- fix: 2d array type further improvements
- fix: array type
- fix: multidimensional array type
- Merge pull request #18 from thuoe/feature/unit-tests
- build: test step to ci job
- test: create markdown from 2d array
- test: grouping obj
- test: format & select fields
- build: install jest
- Merge pull request #16 from thuoe/feature/thu-32-search-command-create-readme
- docs: add missing command subheading
- docs: create README.md template
- Merge pull request #15 from thuoe/feature/thu-29-player-markdown-season-stats
- feat: include yellow/red card stats
- refactor: set/filter events
- fix: map player id
- feat: fetch player stats across seasons for teams
- feat: create markdown table function
- Merge remote-tracking branch \'origin/next\' into feature/thu-15-raycast-create-search-command
- Merge pull request #14 from thuoe/chore/gh-actions-ci
- build: provide extension description
- refactor: ci pipeline
- Merge remote-tracking branch \'origin/next\' into feature/thu-15-raycast-create-search-command
- Merge pull request #13 from thuoe/feature/thu-28-create-extension-icon
- feat: create extension icon
- feat: create argument to search by team name
- feat: group squad by positions in grid view
- feat: create grouping function
- feat: create simple grid view for squad players
- feat: map tvstations to fixture calendar events
- feat: provide calendar name preference
- feat: wrap action in confirmation alert
- feat: create calendar event action for upcoming fixtures
- feat: icon for player details action button
- feat: introduce limit across fixture list items
- feat: populate upcoming fixtures list section
- fix: correct time range when fetching fixtures
- fix: rename fixture list category
- refactor: format fixture timestamp during response mapping
- feat: fetch latest fixtures and populate list items
- fix: correct squad subtitle count
- fix: populate title & placeholder with team name
- refactor: generic function to compute select fields
- fix: maximise player image size in markdown
- feat: create player details view
- feat: map player dob
- feat: restructure search command to search, favorite & display teams details
- feat: create new view for team details using dummy data
- build: create alias for shared types
- feat: create hook to fetch team with player info
- fix: invoke custom hook after change to path & provide execute flag
- refactor: rename search team command
- fix: prevent persisting dropdown value
- feat: create dropdown with team sections using dummy data
- feat(command): create search command template
- Merge pull request #12 from thuoe/chore/env-var-gh-actions
- chore: default env vars for gh actions
- chore: create basic ci pipeline (#11)
- Merge pull request #6 from thuoe/chore/local-dev-improvements
- fix: add missing package
- chore: format remaining files
- chore: update editorconfig
- chore: format code on save
- chore: create editorconfig file
- Merge pull request #5 from thuoe/feature/thu-23-create-preferences
- refactor: remove optional chaining
- refactor: create custom hook for API call
- feat: test API command
- chore: provide ESLint config (#4)
- Merge pull request #1 from thuoe/feature/thu-14-create-project-template
- feat: create simple command template
- Initial commit

* Update footy-report extension

- Merge pull request #26 from thuoe/next
- Merge pull request #25 from thuoe/bugfix/squad-details
- fix: map fixture id to item key
- fix: increase limit of squad players rendered in grid
- chore: remove console log
- fix: display age && render if dob provided
- fix: show seasons based on relevant team
- fix: filter season stats if no details found
- fix: render players without shirt no
- Merge pull request #23 from thuoe/main

* Update footy-report extension

- Merge pull request #29 from thuoe/next
- Merge pull request #28 from thuoe/feature/thu-34-error-handling-faulty-api-tokens
- fix: handle errors across views
- refactor: hooks response types
- fix: handle hook data responses if invalid token is found
- fix: provide error from promise hook
- feat: create error toast hook
- Merge pull request #27 from thuoe/main

* Update footy-report extension

- Merge pull request #32 from thuoe/next
- Merge pull request #31 from thuoe/feature/thu-35-api-test-command-validate-sportmonks-endpoint
- feat: validate endpoint before submit
- Merge pull request #30 from thuoe/main

* Update CHANGELOG.md and optimise images

---------

Co-authored-by: raycastbot <bot@raycast.com>
raycastbot added a commit that referenced this issue Jan 21, 2024
* Add footy-report extension

- Merge pull request #22 from thuoe/next
- Merge pull request #21 from thuoe/docs/2023-12-26-changelog
- docs: update changelog
- Merge pull request #20 from thuoe/feature/thu-33-redesign-test-api-command
- docs: update screenshots
- chore: delete unused assets
- feat: action to open ext preferences
- feat: use form to test API access token
- Merge pull request #19 from thuoe/bugfix/fetch-teams
- fix: optional position name
- Merge pull request #2 from thuoe/feature/thu-15-raycast-create-search-command
- Merge pull request #10 from thuoe/feature/thu-26-create-command-screenshots
- docs: include command screenshots in README.md
- docs: player stats screenshot
- docs: team list screenshot
- docs: update team details & API screenshots
- docs: delete outdated screenshots
- docs: create command screenshots
- Merge pull request #17 from thuoe/bugfix/type-errors
- build: include build step during CI pipeline
- fix: type error fetch teams hook
- fix: type error command arg
- fix: type errors for fetching fixtures
- fix: type erros from player stats
- fix: 2d array type further improvements
- fix: array type
- fix: multidimensional array type
- Merge pull request #18 from thuoe/feature/unit-tests
- build: test step to ci job
- test: create markdown from 2d array
- test: grouping obj
- test: format & select fields
- build: install jest
- Merge pull request #16 from thuoe/feature/thu-32-search-command-create-readme
- docs: add missing command subheading
- docs: create README.md template
- Merge pull request #15 from thuoe/feature/thu-29-player-markdown-season-stats
- feat: include yellow/red card stats
- refactor: set/filter events
- fix: map player id
- feat: fetch player stats across seasons for teams
- feat: create markdown table function
- Merge remote-tracking branch \'origin/next\' into feature/thu-15-raycast-create-search-command
- Merge pull request #14 from thuoe/chore/gh-actions-ci
- build: provide extension description
- refactor: ci pipeline
- Merge remote-tracking branch \'origin/next\' into feature/thu-15-raycast-create-search-command
- Merge pull request #13 from thuoe/feature/thu-28-create-extension-icon
- feat: create extension icon
- feat: create argument to search by team name
- feat: group squad by positions in grid view
- feat: create grouping function
- feat: create simple grid view for squad players
- feat: map tvstations to fixture calendar events
- feat: provide calendar name preference
- feat: wrap action in confirmation alert
- feat: create calendar event action for upcoming fixtures
- feat: icon for player details action button
- feat: introduce limit across fixture list items
- feat: populate upcoming fixtures list section
- fix: correct time range when fetching fixtures
- fix: rename fixture list category
- refactor: format fixture timestamp during response mapping
- feat: fetch latest fixtures and populate list items
- fix: correct squad subtitle count
- fix: populate title & placeholder with team name
- refactor: generic function to compute select fields
- fix: maximise player image size in markdown
- feat: create player details view
- feat: map player dob
- feat: restructure search command to search, favorite & display teams details
- feat: create new view for team details using dummy data
- build: create alias for shared types
- feat: create hook to fetch team with player info
- fix: invoke custom hook after change to path & provide execute flag
- refactor: rename search team command
- fix: prevent persisting dropdown value
- feat: create dropdown with team sections using dummy data
- feat(command): create search command template
- Merge pull request #12 from thuoe/chore/env-var-gh-actions
- chore: default env vars for gh actions
- chore: create basic ci pipeline (#11)
- Merge pull request #6 from thuoe/chore/local-dev-improvements
- fix: add missing package
- chore: format remaining files
- chore: update editorconfig
- chore: format code on save
- chore: create editorconfig file
- Merge pull request #5 from thuoe/feature/thu-23-create-preferences
- refactor: remove optional chaining
- refactor: create custom hook for API call
- feat: test API command
- chore: provide ESLint config (#4)
- Merge pull request #1 from thuoe/feature/thu-14-create-project-template
- feat: create simple command template
- Initial commit

* Update footy-report extension

- Merge pull request #26 from thuoe/next
- Merge pull request #25 from thuoe/bugfix/squad-details
- fix: map fixture id to item key
- fix: increase limit of squad players rendered in grid
- chore: remove console log
- fix: display age && render if dob provided
- fix: show seasons based on relevant team
- fix: filter season stats if no details found
- fix: render players without shirt no
- Merge pull request #23 from thuoe/main

* Update footy-report extension

- Merge pull request #29 from thuoe/next
- Merge pull request #28 from thuoe/feature/thu-34-error-handling-faulty-api-tokens
- fix: handle errors across views
- refactor: hooks response types
- fix: handle hook data responses if invalid token is found
- fix: provide error from promise hook
- feat: create error toast hook
- Merge pull request #27 from thuoe/main

* Update footy-report extension

- Merge pull request #32 from thuoe/next
- Merge pull request #31 from thuoe/feature/thu-35-api-test-command-validate-sportmonks-endpoint
- feat: validate endpoint before submit
- Merge pull request #30 from thuoe/main

* Update CHANGELOG.md and optimise images

* Update footy-report extension

- Merge pull request #37 from thuoe/next
- Merge pull request #36 from thuoe/chore/sync-raycast-repo
- Merge branch \'contributions/merge-1705420963700882000\' into chore/sync-raycast-repo
- Pull contributions
- Merge pull request #35 from thuoe/next
- Merge pull request #24 from thuoe/feature/thu-18-raycast-command-search-league-standings
- docs: update timestamp
- fix: filter only domestic leagues
- Merge remote-tracking branch \'origin/next\' into feature/thu-18-raycast-command-search-league-standings
- docs: include install button (#34)
- Merge pull request #33 from thuoe/main
- Merge remote-tracking branch \'origin/next\' into feature/thu-18-raycast-command-search-league-standings
- docs: update changelog
- feat: action to open team details from standing
- docs: include command screenshot
- feat: include search bar placeholder
- fix: map league id
- feat: display standing once league is selected
- feat: map recent form for each standing
- fix: map image path
- feat: map matches played
- feat: create hook to fetch league standing data
- fix: map active season
- feat: fetch leagues

* Already an install button 🙂

* fix: error handle invalid api tokens for fetching standings (#38)

* fix: linting issues (#39)

* fix: error handle fetch league hook (#40)

* Update README.md

* Update CHANGELOG.md and optimise images

---------

Co-authored-by: raycastbot <bot@raycast.com>
Co-authored-by: Per Nielsen Tikær <per@raycast.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues related to API bug Something isn't working status: fixed in next release The issue will be closed once next release is available
Projects
None yet
Development

No branches or pull requests

3 participants