-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Extension "TT": Translator #1009
Conversation
feat: update with transparent logo
Congratulation on your new Raycast extension! 🚀 We will review it shortly. Once the PR is approved and merged, the extension will be available on the Store. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @deptno 👋
Thanks for your contribution 🔥, well done! I have some comments for you:
- There is already an open PR with papago search Add Papago extension #888 started by @wooogle – it would make sense to use one of the extension as a base and both contribute.
Some feedback for your extension
- At the moment, Raycast doesn't support localization and only supports US English.
- The name of the command needs to be understandable, check Naming convention
- Do I need to register for a key before “history” and does that make any sense?
- We do already have Google Translate so it makes sense to make the Papago translater and focus on that?
Let me know your thoughts
Thank you for your feedback. I reflected them in this extension.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @deptno 👋
Thanks for the update 💪
I have some suggestions and comments for you to address:
- I'm not sure how the
history
works, tried a lot of searches but seems like nothing ends in the history? - Are you in Slack, would love to have an API key for 15 minutes to test it fully out.
Request a new review when you are ready, feel free to contact me here or at Slack if you have any questions.
{ | ||
"name": "index", | ||
"title": "Transator", | ||
"subtitle": "Translate texts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"subtitle": "Translate texts", | |
"subtitle": "Papago", |
{ | ||
"$schema": "https://www.raycast.com/schemas/extension.json", | ||
"name": "tt", | ||
"title": "TT", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"title": "TT", | |
"title": "Papago Translator", |
@@ -0,0 +1,929 @@ | |||
{ | |||
"$schema": "https://www.raycast.com/schemas/extension.json", | |||
"name": "tt", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"name": "tt", | |
"name": "papago-translator", |
Co-authored-by: Per Nielsen Tikær <per@tikaer.dk>
Co-authored-by: Per Nielsen Tikær <per@tikaer.dk>
Thank you for your feedbacks.
So, "Papago" can't be name of the extension.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @deptno 👋
- Makes sense 😄
- Ah, seems like a section title caused the confusion
I have some suggestions for you:
- I would move the credentials to preferences instead, would fit how the rest of Raycast is working.
- After adding the key, then it seems like it's not happy fetching the result 😄
- Icon is missing in the ActionPanel here:
Request a new review when you are ready, feel free to contact me here or at Slack if you have any questions.
Thank you for feedbacks! I agree that section title caused the confusion. so I removed I have question. Can you tell me your preferences values?
I converted PR status to draft. I will mention you again soon. |
I selected Danish to English 😄 |
Hi @deptno 👋 Do you have an update here? |
I'm not able to work on this now. |
Description
Add
TT
extension to translate texts with multiple providers.From
language,To
language are configurable.TT
extension will be supported.Screencast
t.mov
Checklist
npm run build
and tested this distribution build in Raycastassets
folder are used by the extension itselfREADME
are placed in themedia
folder