Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drupal-api extension #12075

Closed
wants to merge 8 commits into from
Closed

Conversation

BossElijah
Copy link
Contributor

@BossElijah BossElijah commented Apr 29, 2024

Description

This extension lets you search Drupal API documentation directly from Raycast.

Screencast

drupal-api-1
drupal-api-3
drupal-api-5

Checklist

@raycastbot raycastbot added the new extension Label for PRs with new extensions label Apr 29, 2024
@raycastbot
Copy link
Collaborator

Congratulations on your new Raycast extension! 🚀

We will aim to make the initial review within five working days. Once the PR is approved and merged, the extension will be available on our Store.

- Update images
- Set sizes on icons in readme
- Update readme
- Add functionality for users to select which version of Drupal to search
- Add metadata images
- Move images referenced in README to media dir
- Add keyboard shortcuts + minor cleanup
- Fix extension after api.drupal.org\'s breaking changes
@pernielsentikaer
Copy link
Collaborator

Hi 👋

Thanks for your contribution 🔥

Would it make sense to add to this extension by @hussainweb and mke that one a more general one instead?

@pernielsentikaer pernielsentikaer self-assigned this May 6, 2024
@BossElijah
Copy link
Contributor Author

Hi @pernielsentikaer.
I thought about it as well, but it seems hussainweb wants their extension to be more general, while I like the simplicity of this one. Being able to browse through the API is a crucial part of every day Drupal module development while the other extension seems to be more directed at developers developing Drupal itself.

I just defended why I want is as a separate extension, but you're more than welcome to tell me if you think otherwise.

Thank you!

@pernielsentikaer
Copy link
Collaborator

Having it in the same extension might not be bad, both things is developer related, right?

Let's see what @hussainweb says :)

@hussainweb
Copy link
Contributor

Thanks for writing this. It's a really good idea. It's also one of the things I want to include in my extension anyway. Considering that this extension is also reading the details from Drupal.org, I think there is a strong overlap. I can't think of any advantage in having a separate extension for API documentation when it is already in scope of the drupal-org extension.

To that end, I am happy to help merge this functionality in my extension. If you agree, let's discuss on what's a good way to do that. Of course, I would also like to credit you as the author. I have to check how Raycast attributes multiple authors/contributors on an extension.

@BossElijah
Copy link
Contributor Author

Alright @hussainweb, sounds good. What is the procedure then? Do we close this PR and I make a PR on the other extension? I'll be happy to try to integrate it into your extension if that's ok with you.

@hussainweb
Copy link
Contributor

That's great. Do you want to directly add it to my repo and we can then submit a combined PR here? This model of a mega repository is a bit new to me and I'm open to other ideas.

@pernielsentikaer what do you suggest is the best way forward in this scenario?

@pernielsentikaer
Copy link
Collaborator

The easiest way is to download the extension inside Raycast and use the action Fork extension. Then open in your editor and run npx @raycast/migration@latest . this way it updates to the newest version of everything and then you can add your changes with git commit -am "update" and use npx @raycast/api@latest publish to open a PR

@BossElijah
Copy link
Contributor Author

Just created a PR for the other drupal extension: #12239

@pernielsentikaer should we close this PR?

@pernielsentikaer
Copy link
Collaborator

Let's close this yes 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new extension Label for PRs with new extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants