Update: Slack: Adding more info to Slack Open Channel command #13343

RobErskine · 2024-07-05T21:12:48Z

Description

Hi there! I updated the Slack Search Command to pull more data from Slack, like the user's Title (if it exists), their current status in Slack, when they will be back, their timezone location, as well as their current local time.

Current Search Command UI

New Search Command UI

Screencast

Code-search.tsx.slack_2024-07-05.at.16.49.mp4

Bonus

Adds Emojify to Unread Messages as well to help make messages with emojis more readable:

Checklist

I read the extension guidelines
I read the documentation about publishing
I ran npm run build and tested this distribution build in Raycast
I checked that files in the assets folder are used by the extension itself
I checked that assets used by the README are placed outside of the metadata folder

raycastbot · 2024-07-05T21:13:04Z

Thank you for your contribution! 🎉

🔔 @momme-rtf @Elliot67 @jfkisafk @thomaslombart you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

We're currently experiencing high demand and limited capacity. As a result, extension reviews might take longer than usual to get the initial review. Please expect an initial review within 5-10 business days.

…aycast-extensions into feature/slack-search-update

momme-rtf · 2024-07-05T23:09:23Z

Hi @RobErskine
Thanks for your contribution! I like your change for displaying the emojis properly.
Regarding the search: I personally like to have the list more focused and less overloaded with infos. Especially when working within a small team I rather do not care about titles and locations of team members. Within a bigger company I see that it can be helpful. Maybe we could make it configurable somehow what we show. But I'd also like to hear the opinion of other contributers. What do you think?

RobErskine · 2024-07-06T01:30:47Z

Hi @momme-rtf, thanks for your thoughts. I can see your point about keeping it uncluttered. Personally my org on Slack is over 700 people all over the world, so looking people up and understanding where they are and what time it is for them is crazy useful for me.

I do like your suggestion of adding in a Preference for this though to keep this simple for folks that like the way it is currently. I was already thinking in the shower that I should probably add in a preference for how the time should be displayed (am/pm or 24 hour).

How about this:

Add in a Preference for whether to show time in am/pm or 24 hour
Add in a Preference on whether or not to show the Timezone / current time for that team member
I think it's useful to show the Slack status emoji, the message, and when the status expires. Do you think that would be a good addition to keep in, without a Preference to toggle on/off?

jfkisafk

LGTM other than the broader conversation we are having around preferences.

extensions/slack/package.json

extensions/slack/src/search.tsx

extensions/slack/CHANGELOG.md

extensions/slack/package.json

…h results

RobErskine · 2024-07-07T18:43:46Z

👋🏼 hey @jfkisafk @momme-rtf,

I went ahead and added two additional preferences to the extension for Time Format as well as Displaying Additional Metadata in the Search Command:

I also added in HH:MM to the Slack Status Tooltip so if someone is grabbing lunch, or at a doctor's appt on the same day, the return time will be displayed. This screenshot also has the "Show Extra Metadata" option turned off (which is the default).

Here is what it looks like with the extra metadata turned on, as well as the 24 hour time format.

Let me know if you have any other feedback!

momme-rtf · 2024-07-07T19:38:42Z

Awesome @RobErskine
The preferences that you've added look good to me :)

jfkisafk

Minor comments but lgtm 🚀

extensions/slack/src/shared/client/WebClient.ts

extensions/slack/package.json

extensions/slack/src/search.tsx

Co-authored-by: stelo <42366677+jfkisafk@users.noreply.github.com>

jfkisafk

Minor suggested changes for type casting the preferences from raycast-env.d.ts, but not required. Ty for this awsum addition 🫶

jfkisafk · 2024-07-08T03:17:55Z

extensions/slack/src/search.tsx


-const { displayExtraMetadata } = getPreferenceValues<Preferences>();
+const { displayExtraMetadata } = getPreferenceValues();


Suggested change

const { displayExtraMetadata } = getPreferenceValues();

const { displayExtraMetadata } = getPreferenceValues<Preferences.Search>();

jfkisafk · 2024-07-08T03:18:18Z

extensions/slack/src/shared/utils.ts


 function getTimeLocale(): string {
-  const timeFormat = getPreferenceValues<Preferences>().timeFormat;
+  const timeFormat = getPreferenceValues().timeFormat;


Suggested change

const timeFormat = getPreferenceValues().timeFormat;

const timeFormat = getPreferenceValues<Preferences>().timeFormat;

jfkisafk · 2024-07-08T09:21:24Z

Please rebase on top of #13039 and see if everything works as before? This will add a new command and the previous Search command name has changed.

…h results

…aycast-extensions into feature/slack-search-update # Conflicts: # extensions/slack/CHANGELOG.md # extensions/slack/package.json # extensions/slack/src/search.tsx # extensions/slack/src/shared/client/SlackClient.ts # extensions/slack/src/shared/utils.ts # extensions/slack/src/unread-messages.tsx

RobErskine · 2024-07-08T17:50:31Z

👋🏼 hi there.

This is pretty poor (or good?) timing on my end but I was working on an update to the ~~Search~~ Open Channel command just as @thomaslombart published the latest Slack extension updates.

This PR adds Metadata to the Open Channel command to show Slack member's job title, current status, timezone, as well as their current time. Also added in the option to display time in AM/PM or 24 hour time.

With the Metadata set to false (this is the default to keep functionality as close to what it is now):

With the Metadata turned on (with 24 hour time):

thomaslombart · 2024-07-11T07:03:54Z

Hey Rob, I'll review the PR next week 🙂

thomaslombart · 2024-07-15T08:14:07Z

It seems other extension changes have slipped in while merging/rebasing. Could you fix it before I review your PR? 🙂

RobErskine · 2024-07-15T20:48:09Z

@thomaslombart sorry about that; not sure how that happened while I was rebasing. I have merged main back in and all looks correct now. Mind giving it a look now?

extensions/slack/src/shared/utils.ts

RobErskine added 2 commits July 5, 2024 16:59

Update: Slack: Adding more info to Slack Search

d34ba4a

Add: Slack: Adds Emojify to Unread Messages command

c02cb5b

RobErskine requested a review from thomaslombart as a code owner July 5, 2024 21:12

raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: slack Issues related to the slack extension labels Jul 5, 2024

RobErskine added 3 commits July 5, 2024 17:13

Add: Slack: Adds Emojify to Unread Messages command

6188715

Merge branch 'feature/slack-search-update' of github.com:RobErskine/r…

a469cbc

…aycast-extensions into feature/slack-search-update

Add: Slack: Update emojify helper function to unread message detail

b76c636

jfkisafk reviewed Jul 6, 2024

View reviewed changes

extensions/slack/package.json Outdated Show resolved Hide resolved

extensions/slack/src/search.tsx Outdated Show resolved Hide resolved

extensions/slack/CHANGELOG.md Outdated Show resolved Hide resolved

extensions/slack/package.json Show resolved Hide resolved

Add: Slack: Adding optional preferences to allow flexibility in searc…

86dbe6a

…h results

Slack: Linting fix

155f797

jfkisafk approved these changes Jul 7, 2024

View reviewed changes

extensions/slack/src/shared/client/WebClient.ts Outdated Show resolved Hide resolved

extensions/slack/package.json Outdated Show resolved Hide resolved

extensions/slack/src/search.tsx Outdated Show resolved Hide resolved

extensions/slack/src/search.tsx Outdated Show resolved Hide resolved

RobErskine and others added 2 commits July 7, 2024 20:31

Update extensions/slack/src/search.tsx

7c83f90

Co-authored-by: stelo <42366677+jfkisafk@users.noreply.github.com>

Slack: Addressing minor feedback

2f6cdae

jfkisafk approved these changes Jul 8, 2024

View reviewed changes

RobErskine added 7 commits July 8, 2024 11:32

Slack search: type casting preferences from raycast-env.d.ts

90fc50f

Update: Slack: Adding more info to Slack Search

bdcc780

Add: Slack: Adds Emojify to Unread Messages command

71576c4

Add: Slack: Adding optional preferences to allow flexibility in searc…

a0aa7d4

…h results

Slack: Addressing minor feedback

578efea

Slack search: type casting preferences from raycast-env.d.ts

c6d8ca4

RobErskine requested review from mathieudutour and thomaspaulmann as code owners July 8, 2024 17:44

RobErskine requested review from peduarte, pernielsentikaer, mil3na and bangerang as code owners July 8, 2024 17:44

RobErskine changed the title ~~Update: Slack: Adding more info to Slack Search~~ Update: Slack: Adding more info to Slack Open Channel command Jul 8, 2024

jfkisafk approved these changes Jul 8, 2024

View reviewed changes

thomaslombart self-assigned this Jul 11, 2024

Merge branch 'raycast:main' into feature/slack-search-update

1138934

jfkisafk approved these changes Jul 15, 2024

View reviewed changes

extensions/slack/src/shared/utils.ts Outdated Show resolved Hide resolved

slack open channel: destructuring time format

fee8e4b

jfkisafk approved these changes Jul 16, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update: Slack: Adding more info to Slack Open Channel command #13343

Update: Slack: Adding more info to Slack Open Channel command #13343

RobErskine commented Jul 5, 2024 •

edited

Loading

raycastbot commented Jul 5, 2024 •

edited

Loading

momme-rtf commented Jul 5, 2024

RobErskine commented Jul 6, 2024 •

edited

Loading

jfkisafk left a comment

RobErskine commented Jul 7, 2024

momme-rtf commented Jul 7, 2024

jfkisafk left a comment

jfkisafk left a comment

jfkisafk Jul 8, 2024

jfkisafk Jul 8, 2024

jfkisafk commented Jul 8, 2024

RobErskine commented Jul 8, 2024 •

edited

Loading

thomaslombart commented Jul 11, 2024

thomaslombart commented Jul 15, 2024

RobErskine commented Jul 15, 2024


		const { displayExtraMetadata } = getPreferenceValues<Preferences>();
		const { displayExtraMetadata } = getPreferenceValues();

	const timeFormat = getPreferenceValues().timeFormat;
	const timeFormat = getPreferenceValues<Preferences>().timeFormat;

Update: Slack: Adding more info to Slack Open Channel command #13343

Are you sure you want to change the base?

Update: Slack: Adding more info to Slack Open Channel command #13343

Conversation

RobErskine commented Jul 5, 2024 • edited Loading

Description

Current Search Command UI

New Search Command UI

Screencast

Bonus

Checklist

raycastbot commented Jul 5, 2024 • edited Loading

momme-rtf commented Jul 5, 2024

RobErskine commented Jul 6, 2024 • edited Loading

jfkisafk left a comment

Choose a reason for hiding this comment

RobErskine commented Jul 7, 2024

momme-rtf commented Jul 7, 2024

jfkisafk left a comment

Choose a reason for hiding this comment

jfkisafk left a comment

Choose a reason for hiding this comment

jfkisafk Jul 8, 2024

Choose a reason for hiding this comment

jfkisafk Jul 8, 2024

Choose a reason for hiding this comment

jfkisafk commented Jul 8, 2024

RobErskine commented Jul 8, 2024 • edited Loading

thomaslombart commented Jul 11, 2024

thomaslombart commented Jul 15, 2024

RobErskine commented Jul 15, 2024

RobErskine commented Jul 5, 2024 •

edited

Loading

raycastbot commented Jul 5, 2024 •

edited

Loading

RobErskine commented Jul 6, 2024 •

edited

Loading

RobErskine commented Jul 8, 2024 •

edited

Loading