Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dolar-cripto-ar extension #13390

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

koaladlt
Copy link
Contributor

@koaladlt koaladlt commented Jul 9, 2024

Description

Fixed Abort Controller Handling: Previously, users were seeing an error message indicating that fetch requests were being aborted. This was due to premature aborts caused by the Abort Controller logic. The issue has now been resolved by refining the abort controller handling and state management.

Improved Error Handling: Implemented a more robust error handling mechanism to ensure that only genuine errors are reported to the user, avoiding false alarms and improving the overall user experience.

Screencast

Checklist

- Merge branch \'contributions/merge-1720529473372495000\'
- Pull contributions
- fix: better error handling
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: dolar-cripto-ar Issues related to the dolar-cripto-ar extension OP is author The OP of the PR is the author of the extension labels Jul 9, 2024
@raycastbot
Copy link
Collaborator

raycastbot commented Jul 9, 2024

Thank you for your contribution! 🎉

🔔 @koaladlt you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

We're currently experiencing high demand and limited capacity. As a result, extension reviews might take longer than usual to get the initial review. Please expect an initial review within 5-10 business days.

@koaladlt koaladlt marked this pull request as draft July 10, 2024 18:31
@mil3na mil3na assigned mil3na and unassigned mil3na Jul 11, 2024
@koaladlt koaladlt marked this pull request as ready for review July 12, 2024 12:54
@mil3na mil3na self-assigned this Jul 16, 2024
Copy link
Contributor

@mil3na mil3na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!
Thank you for your contribution! My name is Milena and I will be reviewing it today.

It looks good on my side. However, I see a lot of console.logs. Are they necessary or can you remove them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension: dolar-cripto-ar Issues related to the dolar-cripto-ar extension extension fix / improvement Label for PRs with extension's fix improvements OP is author The OP of the PR is the author of the extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants