-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dolar-cripto-ar extension #13390
base: main
Are you sure you want to change the base?
Conversation
- Merge branch \'contributions/merge-1720529473372495000\' - Pull contributions - fix: better error handling
Thank you for your contribution! 🎉 🔔 @koaladlt you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. We're currently experiencing high demand and limited capacity. As a result, extension reviews might take longer than usual to get the initial review. Please expect an initial review within 5-10 business days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
Thank you for your contribution! My name is Milena and I will be reviewing it today.
It looks good on my side. However, I see a lot of console.logs
. Are they necessary or can you remove them?
Description
Fixed Abort Controller Handling: Previously, users were seeing an error message indicating that fetch requests were being aborted. This was due to premature aborts caused by the Abort Controller logic. The issue has now been resolved by refining the abort controller handling and state management.
Improved Error Handling: Implemented a more robust error handling mechanism to ensure that only genuine errors are reported to the user, avoiding false alarms and improving the overall user experience.
Screencast
Checklist
npm run build
and tested this distribution build in Raycastassets
folder are used by the extension itselfREADME
are placed outside of themetadata
folder