-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Todoist] Today's Frog #2775
[Todoist] Today's Frog #2775
Conversation
Thank you for your first contribution! 🎉 🔔 @thomaslombart you might want to have a look. |
Hey @aromeronavia, thanks for the contribution! 🎉 It looks good to me except for the "frog" part which feels too opinionated to be part of the Todoist extension since the latter is designed to manage Todoist tasks in a generic way. |
Hey @thomaslombart! Appreciate you taking a look at this. I wonder if we can swap Frog with "Focus"? |
@thomaslombart PR ready to review again 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review. It looks good to me 👍
Maybe the last suggestion would be to rename the command Today's Focus
to Today's Tasks
. The focus part seems to be secondary here 🙂
Hey @thomaslombart! Sorry again for taking so long to respond. Regarding your comment, there is already a Today Tasks command in the extension, so I think it will be more confusing if we add
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊 |
It shouldn't be stale. @aromeronavia should I take back this PR? |
9c553dc
to
c6b5433
Compare
@aromeronavia There's another PR for the menu bar command that is packed with more features: #3597. |
I agree with closing this one in favor of the other PR, I actually like it more. I'm closing by now 👍 |
Description
Added a Menu Bar Command to display Today's Frog, which means the most important task you need to finish Today.
How I implemented it:
frog
)today-frog.tsx
file with the logic to filtertoday|overdue
tasks to identify if there's a frog, and if not, it will just display the first task in the list of Today's tasksScreencast
raycast-todoist-evidence.mov
Checklist
npm run build
and tested this distribution build in Raycastassets
folder are used by the extension itselfREADME
are placed outside of themetadata
folder