Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Todoist] Today's Frog #2775

Closed

Conversation

aromeronavia
Copy link
Contributor

@aromeronavia aromeronavia commented Sep 2, 2022

Description

Added a Menu Bar Command to display Today's Frog, which means the most important task you need to finish Today.
How I implemented it:

  1. Added a Preferences Variable to set the label that will filter Today's Frog (Defaulted to frog)
  2. Added a Menu Bar Command to Package.json
  3. Added a today-frog.tsx file with the logic to filter today|overdue tasks to identify if there's a frog, and if not, it will just display the first task in the list of Today's tasks

Screencast

raycast-todoist-evidence.mov

Checklist

@raycastbot raycastbot added the extension fix / improvement Label for PRs with extension's fix improvements label Sep 2, 2022
@raycastbot
Copy link
Collaborator

raycastbot commented Sep 2, 2022

Thank you for your first contribution! 🎉

🔔 @thomaslombart you might want to have a look.

@thomaslombart
Copy link
Collaborator

Hey @aromeronavia, thanks for the contribution! 🎉

It looks good to me except for the "frog" part which feels too opinionated to be part of the Todoist extension since the latter is designed to manage Todoist tasks in a generic way.

@aromeronavia
Copy link
Contributor Author

Hey @thomaslombart! Appreciate you taking a look at this.

I wonder if we can swap Frog with "Focus"? Today's Focus would be the Command name, and we could replace the Frog tag with Focus one. I will do this change and will let you know when it's done

@aromeronavia
Copy link
Contributor Author

@thomaslombart PR ready to review again 👍

Copy link
Collaborator

@thomaslombart thomaslombart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. It looks good to me 👍

Maybe the last suggestion would be to rename the command Today's Focus to Today's Tasks. The focus part seems to be secondary here 🙂

@aromeronavia
Copy link
Contributor Author

Hey @thomaslombart!

Sorry again for taking so long to respond. Regarding your comment, there is already a Today Tasks command in the extension, so I think it will be more confusing if we add Today's Tasks. Some proposals for naming:

  • Focus Task
  • Menu Bar Task
  • Show Tasks in Menu Bar

@thomaslombart
Copy link
Collaborator

Not sure if it's that confusing since Raycast clearly indicates it's a menu bar command:

Here's an example with Google Workspace:
Raycast 2022-10-13 at 16 23 33

What do you think?

@stale
Copy link

stale bot commented Nov 17, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊

@stale stale bot added the status: stalled Stalled due inactivity label Nov 17, 2022
@thomaslombart
Copy link
Collaborator

It shouldn't be stale. @aromeronavia should I take back this PR?

@stale stale bot removed the status: stalled Stalled due inactivity label Nov 17, 2022
@thomaslombart
Copy link
Collaborator

@aromeronavia There's another PR for the menu bar command that is packed with more features: #3597.

@aromeronavia
Copy link
Contributor Author

I agree with closing this one in favor of the other PR, I actually like it more. I'm closing by now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension fix / improvement Label for PRs with extension's fix improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants