Harvest #585

eluce2 · 2021-12-31T23:00:01Z

Description

Fix: Update SWR package to 1.1.2 (handles window.requestAnimationFrame bug)
Fix: Harvest admins are now limited to only view their own time entries, even if their API creds allow them to view/edit other user's timers in their company.
New: Support for viewing timers on other days (see below)
New: Add user preference to control how time entries are sorted
Improvement: Remove brackets in project picker if no code is present (fixes [Extension Bug] Harvest - @eluce2 #538)
Improvement: Project picker now groups projects by client (more similar the Harvest app)
Improvement: Now uses new alert dialog for deleting time entry confirmation
Improvement: Total hours for a given day are shown in the header of the list of time entries

NOTE: The new feature that allows editing entries on other days is incomplete, but until there is a Date only form field component, I can't get it to function correctly. Expected behavior is that you would navigate to a different day, then choose the "New Timer" action and the date field would be prefilled to the day that you had navigated to. Due to timezone differences, if I put any date in as the default value, it displays as 6 pm on the previous day. To me, this behavior is worse than not pre-setting the date at all, so I've disabled that part of the feature for now. However, if the date field is left blank, the API will still create the time entry on the correct date this is just not made clear to the user in the form.

Also, please note it was an intentional decision to change the navigation header when switching days, as otherwise there would be no indication of which is your current day if there are no time entires on that day.

Type of change

Bug fix / improvement for my extension

Screencast

https://cln.sh/meou3X

Checklist

I read the extension guidelines
I read the documentation about publishing

unnamedd

Hey @eluce2, would you please do not modify other extensions?
I saw you are making changes on my Script Commands Store extension and also in the Two Factor Authentication as well.

Please, rollback those changes.

Tip: when you develop you extension, open on VSCode only the folder of your extension, if you open the extensions root folder and apply a formatter, it might make unwanted changes on other files.

eluce2 · 2022-01-01T03:27:21Z

@unnamedd Sorry about that, this new commit should only effect my own extension. Thanks for the tip, I'll be sure to use that in my future development!

pernielsentikaer

Hi @eluce2 👋

It sounds like some nice additions to the extension 💪

In the README recognize is spelled wrong 😄
There is no gracefully handling when token are wrong, can you also add this?

Request a new review when you are ready, feel free to contact me here or at Slack if you have any questions.

pernielsentikaer

hi @eluce2 👋

Did you push it correct? It seems like I'm still facing the same hard error 😄

eluce2 · 2022-01-03T02:09:49Z

@pernielsentikaer So that looks like a different error than "invalid API token". At first, I was unable to replicate, but that's because I've been testing with the node production environment. Could this be something polyfilled by the Raycast Dev API, or do I need to adjust my code? Again, you won't get that error when it's running in production.

pernielsentikaer · 2022-01-03T06:21:10Z

Hi @eluce2 👋

Just to be sure once more, sorry, If I get the extension from Store right now, this is the error you have fixes, yes? (The one with wrong credentials)

eluce2 · 2022-01-03T17:50:40Z

Yes, I'm trapping for the 401 HTTP response now in the latest push, and showing a generic error for any other non-success HTTP statuses

pernielsentikaer

hi @eluce2 👋

Thanks for the update. I'm going to accept it and then will my colleague do a final review before it's finally merged 😄

mathieudutour · 2022-01-04T08:10:51Z

extensions/harvest/src/listTimeEntries.tsx

+      if (error.isAxiosError) {
+        if (error.response?.status === 401) {
+          await showToast(
+            ToastStyle.Failure,
+            "Invalid Token",
+            "Your API token or Account ID is invalid. Go to Raycast Preferences to update it."
+          );
+        }
+      } else {
+        await showToast(ToastStyle.Failure, "Unknown Error", "Could not fetch time entries");
+      }


Shouldn't it be

Suggested change

if (error.isAxiosError) {

if (error.response?.status === 401) {

await showToast(

ToastStyle.Failure,

"Invalid Token",

"Your API token or Account ID is invalid. Go to Raycast Preferences to update it."

);

}

} else {

await showToast(ToastStyle.Failure, "Unknown Error", "Could not fetch time entries");

}

if (error.isAxiosError) {

if (error.response?.status === 401) {

await showToast(

ToastStyle.Failure,

"Invalid Token",

"Your API token or Account ID is invalid. Go to Raycast Preferences to update it."

);

} else {

await showToast(ToastStyle.Failure, "Unknown Error", "Could not fetch time entries");

}

} else {

await showToast(ToastStyle.Failure, "Unknown Error", "Could not fetch time entries");

}

so that a 500 or whatever also shows a toast? We might want to show the error message as well (if any, I'm not familiar with the API)

Yes, good catch. I'll add that

extensions/harvest/src/listTimeEntries.tsx

Co-authored-by: Mathieu Dutour <mathieu@dutour.me>

mathieudutour

Thanks!

raycastbot · 2022-01-04T14:15:37Z

Published to the Raycast Store:
https://raycast.com/eluce2/harvest

* revert rebase * graceful error handling of invalid API token * readme spellcheck fix * fix typechecking of error clause * Update extensions/harvest/src/listTimeEntries.tsx Co-authored-by: Mathieu Dutour <mathieu@dutour.me> * add else case to support other HTTP statuses Co-authored-by: Mathieu Dutour <mathieu@dutour.me>

eluce2 requested a review from mattisssa as a code owner December 31, 2021 23:00

eluce2 force-pushed the harvest branch from 986305b to 2ba38a8 Compare December 31, 2021 23:06

unnamedd suggested changes Jan 1, 2022

View reviewed changes

revert rebase

81c8ea1

eluce2 force-pushed the harvest branch from 2ba38a8 to 81c8ea1 Compare January 1, 2022 03:24

pernielsentikaer requested changes Jan 2, 2022

View reviewed changes

pernielsentikaer self-assigned this Jan 2, 2022

pernielsentikaer added new extension Label for PRs with new extensions extension fix / improvement Label for PRs with extension's fix improvements and removed new extension Label for PRs with new extensions labels Jan 2, 2022

eluce2 added 3 commits January 2, 2022 09:10

graceful error handling of invalid API token

46484ea

readme spellcheck fix

559ef61

fix typechecking of error clause

26ca75c

eluce2 requested a review from pernielsentikaer January 2, 2022 15:15

pernielsentikaer requested changes Jan 2, 2022

View reviewed changes

pernielsentikaer added the accepted label Jan 3, 2022

pernielsentikaer approved these changes Jan 3, 2022

View reviewed changes

mathieudutour reviewed Jan 4, 2022

View reviewed changes

extensions/harvest/src/listTimeEntries.tsx Outdated Show resolved Hide resolved

eluce2 and others added 2 commits January 4, 2022 08:01

Update extensions/harvest/src/listTimeEntries.tsx

ffa0093

Co-authored-by: Mathieu Dutour <mathieu@dutour.me>

add else case to support other HTTP statuses

a34ccf2

eluce2 requested a review from mathieudutour January 4, 2022 14:04

mathieudutour approved these changes Jan 4, 2022

View reviewed changes

mathieudutour merged commit 374cddf into raycast:main Jan 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Harvest #585

Harvest #585

eluce2 commented Dec 31, 2021

unnamedd left a comment

eluce2 commented Jan 1, 2022

pernielsentikaer left a comment •

edited

pernielsentikaer left a comment

eluce2 commented Jan 3, 2022

pernielsentikaer commented Jan 3, 2022

eluce2 commented Jan 3, 2022

pernielsentikaer left a comment

mathieudutour Jan 4, 2022

eluce2 Jan 4, 2022

mathieudutour left a comment

raycastbot commented Jan 4, 2022

Harvest #585

Harvest #585

Conversation

eluce2 commented Dec 31, 2021

Description

Type of change

Screencast

Checklist

unnamedd left a comment

Choose a reason for hiding this comment

eluce2 commented Jan 1, 2022

pernielsentikaer left a comment • edited

Choose a reason for hiding this comment

pernielsentikaer left a comment

Choose a reason for hiding this comment

eluce2 commented Jan 3, 2022

pernielsentikaer commented Jan 3, 2022

eluce2 commented Jan 3, 2022

pernielsentikaer left a comment

Choose a reason for hiding this comment

mathieudutour Jan 4, 2022

Choose a reason for hiding this comment

eluce2 Jan 4, 2022

Choose a reason for hiding this comment

mathieudutour left a comment

Choose a reason for hiding this comment

raycastbot commented Jan 4, 2022

pernielsentikaer left a comment •

edited