Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weather: Add weather 0.3.0 #74

Merged
merged 6 commits into from
Oct 20, 2021
Merged

Conversation

tonka3000
Copy link
Contributor

@tonka3000 tonka3000 commented Oct 17, 2021

Description

  • Add multi language support for en, de and fr.

    User request via slack (Berenger), The default is the same as before (english), so the user needs to do that proactively.

  • Add better error message

    wttr.in was multiple times down. The error message now try to display possible downtimes from wttr.in.

  • Add support for switching unit system

    Between Metric System (°C, km/h) and Imperial Units (°F, mph). The default is still the Metric System as before, so the user needs to do the change proactively.

  • Add preference to set default query

    The default query will be used when the search bar is empty.
    Request by Aaron Schcolnik Elias via slack

Type of change

  • Bug fix / improvement for my extension

Screencast

User can now choose between english, german and french.

CleanShot 2021-10-17 at 16 25 36@2x

German

raycast_weather_german1

raycast_weather_german2

French

raycast_weather_french1

raycast_weather_french2

Better error message for wttr.in errors

CleanShot 2021-10-17 at 16 55 33@2x

Unit-System

raycast_weather_unitsystem1

raycast_weather_unitsystem2

raycast_weather_unitsystem3

Default query

e.g. set the default query to london.

raycast_weather_defaultquery_non_empty

When the search bar is empty the default value will be used. If not defined, it will behave like older version (nearest location based on ISP).

raycast_weather_default_query_view

Checklist

@PitNikola PitNikola added the extension fix / improvement Label for PRs with extension's fix improvements label Oct 18, 2021
@PitNikola PitNikola self-assigned this Oct 19, 2021
Copy link
Member

@PitNikola PitNikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tonka3000, nice additions. It's cool to see extension evolving based on user feedback, well done 👍

All changes look valid. However I would suggest removing that locale picker. Raycast doesn't support localization across the app and we don't want developers to start partly localizing their extensions, especially in a way where user need to choose something in the dropdown list. This will lead into very inconsistent experience and we would rather have no localization at all than this partial behavior. I think it's perfectly valid to add picker for unit of measurement, but as for locale, we'll need to take it out of this PR before moving forward, sorry.

I'm going to add it to our guidelines. Sorry for the hassle.

@tonka3000
Copy link
Contributor Author

@PitNikola Make totally sense. I removed the multi-language support. I also added icons for the daily forecast icons.

CleanShot 2021-10-20 at 12 44 12@2x

CleanShot 2021-10-20 at 12 45 46@2x

@PitNikola PitNikola merged commit 9cd11fd into raycast:main Oct 20, 2021
FezVrasta pushed a commit to FezVrasta/extensions that referenced this pull request Nov 24, 2021
* add multi language support for en, de and fr

* add better error message

* add support for switching the unit-system

* add default query

* remove multi language support

* add icon for daily forecast items
FezVrasta pushed a commit to FezVrasta/extensions that referenced this pull request Mar 23, 2022
* add multi language support for en, de and fr

* add better error message

* add support for switching the unit-system

* add default query

* remove multi language support

* add icon for daily forecast items
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension fix / improvement Label for PRs with extension's fix improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants