-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weather: Add weather 0.3.0 #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tonka3000, nice additions. It's cool to see extension evolving based on user feedback, well done 👍
All changes look valid. However I would suggest removing that locale picker. Raycast doesn't support localization across the app and we don't want developers to start partly localizing their extensions, especially in a way where user need to choose something in the dropdown list. This will lead into very inconsistent experience and we would rather have no localization at all than this partial behavior. I think it's perfectly valid to add picker for unit of measurement, but as for locale, we'll need to take it out of this PR before moving forward, sorry.
I'm going to add it to our guidelines. Sorry for the hassle.
@PitNikola Make totally sense. I removed the multi-language support. I also added icons for the daily forecast icons. |
* add multi language support for en, de and fr * add better error message * add support for switching the unit-system * add default query * remove multi language support * add icon for daily forecast items
* add multi language support for en, de and fr * add better error message * add support for switching the unit-system * add default query * remove multi language support * add icon for daily forecast items
Description
Add multi language support for en, de and fr.
User request via slack (Berenger), The default is the same as before (english), so the user needs to do that proactively.
Add better error message
wttr.in was multiple times down. The error message now try to display possible downtimes from wttr.in.
Add support for switching unit system
Between
Metric System
(°C, km/h) andImperial Units
(°F, mph). The default is still theMetric System
as before, so the user needs to do the change proactively.Add preference to set default query
The default query will be used when the search bar is empty.
Request by Aaron Schcolnik Elias via slack
Type of change
Screencast
User can now choose between english, german and french.
German
French
Better error message for wttr.in errors
Unit-System
Default query
e.g. set the default query to
london
.When the search bar is empty the default value will be used. If not defined, it will behave like older version (nearest location based on ISP).
Checklist