Abiblity to default-build to attach its output executable binary to maven session

[dantran]

I have maven go build with has many maven modules, each module produce a go executable

Below the dependecyManagement where I disabel mvn-golang lifecycle and only enable default-build

<pluginManagement>
  <plugins>
    <plugin>
      <groupId>com.igormaznitsa</groupId>
      <artifactId>mvn-golang-wrapper</artifactId>
      <executions>
        <!-- turn off default steps -->
        <!-- keep default-build -->
        <execution>
          <id>default-generate</id>
          <phase>none</phase>
        </execution>
        <execution>
          <id>default-fix</id>
          <phase>none</phase>
        </execution>
        <execution>
          <id>default-fmt</id>
          <phase>none</phase>
        </execution>
        <execution>
          <id>default-test</id>
          <phase>none</phase>
        </execution>
        <execution>
          <id>default-mvninstall</id>
          <phase>none</phase>
        </execution>
        <execution>
          <id>default-install</id>
          <phase>none</phase>
        </execution>
        <execution>
          <id>default-build</id>
          <configuration>
            <strip>${go.strip}</strip>
          </configuration>
        </execution>
      </executions>
    </plugin>
  </plugins>
</pluginManagement>

I'd like to have the ability to add an additional setting at default-build configure to attach is build output to maven session.

I currently use maven-antrun-plugin to repeat each child module, like this

<plugins>

  <plugin>
    <groupId>com.igormaznitsa</groupId>
    <artifactId>mvn-golang-wrapper</artifactId>
    <extensions>true</extensions>
    <configuration>
      <workingDir>${golang.src.dir}/${project.artifactId}</workingDir> <!--proprietary path -->
    </configuration>
  </plugin>

  <plugin>
    <artifactId>maven-antrun-plugin</artifactId>
    <executions>
      <execution>
        <id>attach-artifacts</id>
        <phase>package</phase>
        <goals>
          <goal>run</goal>
        </goals>
        <configuration>
          <target>
            <attachartifact file="${project.build.directory}/${project.build.finalName}" type="${exe.ext}" />
          </target>
        </configuration>
      </execution>
    </executions>
  </plugin>

</plugins>

Propose settings for build mojo

<attached>true</attache>
<type>xxxx</type>
<classifier>optional</optional>

[raydac]

there is verbose flag for all goals and if you make it true then it will print output into log <verbose>true</verbose>, also you can turn on it through maven property mvn.golang.verbose

<mvn.golang.verbose>true</mvn.golang.verbose>

[dantran]

@raydac i am not sure about verbose flag anything to do with my request having mvn-golang wrapper to attach the output binary to maven session for install/deploy purpose

[raydac]

yes, looks like that I not correctly understood build output
and why do you use ANT task instead of Maven deploy plugin? it allows to deploy generated file with required parameters into maven repository and use it
or do you mean that you would like to include generated executable file into result artifact archive to be deployed into repository?

[dantran]

using ant:attachartifact is correct, it attaches the build artifact Maven so that my go binary will be installed ( to local repo) and deploy (to remote maven repo)

what I asking is to update https://github.com/raydac/mvn-golang/blob/master/mvn-golang-wrapper/src/main/java/com/igormaznitsa/mvngolang/GolangBuildMojo.java

then attach ${project.build.directory}/${project.build.finalName} to maven session for the same purpose

yes = "or do you mean that you would like to include generated executable file into result artifact archive to be deployed into repository?"

[raydac]

from point of view of maven of course sounds a bit strange to include platform-depended artifact into resulted artifact but idea is good
I think it is no so good to provide such functionality by default but I will add special flag and property into mvn-golang build command to attach result artifact (if it is found after successful execution) into maven session artifacts, ok?

[raydac]

I have added functionality into build mojo, now there are three more properties

• attach - boolean (by default false) which allows turn on attach for built result file (or through property mvn.golang.build.attach)
• attachType - string (by default bin) which allows define type for attached artifact (or through property mvn.golang.build.attach.type)
• attachClassifier - string (by default none) which allows define classifier for attached artifact (or through property mvn.golang.build.attach.classifier)

[dantran]

@raydac awesome

[raydac]

check snapshot pls and if all is ok then pls close the issue

[dantran]

it works. this saves a bunch of repeated antrun plugin block. Thanks

Looking forward to a new release

[rbsrafa]

Hello, I've been testing with this plugin and so far it's amazing.
Regarding this chat, I could get the binary into the generated maven folder, but I'd like to generate it without an extension.
E.g. instead of my-bin.bin -> just my-bin.
I tried to provide a blank attachType but I could see in the src code that it defaults to "bin" if not is provided. Would it be possible to leave the default as an empty string and then provided the desired extension if needed? Thanks

[raydac]

@rbsrafa
attachType is for artifact installation, could you drop example of your pom? do you want generate artifact in repository without type?