Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicate Domain to Root when empty #22

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Replicate Domain to Root when empty #22

merged 2 commits into from
Oct 2, 2023

Conversation

jfroy
Copy link
Contributor

@jfroy jfroy commented Oct 2, 2023

Some entries received from the API do not have a Root field, if the Domain field itself is a root domain. This can cause some problems or special-case handling in dashboards and data pipelines. This patch replicates the Domain to Root when Root is not set.

Fixes #20

jfroy and others added 2 commits October 1, 2023 19:28
Some entries received from the API do not have a Root field, if the
Domain field itself is a root domain. This can cause some problems or
special-case handling in dashboards and data pipelines. This patch
replicates the `Domain` to `Root` when `Root` is not set.

Fixes raylas#20
Copy link
Owner

@raylas raylas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Thanks for the addition.

@raylas raylas merged commit a126ea1 into raylas:main Oct 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some data points have no root label
2 participants