Feature/custom userptr allocator to take into account special hardware-aligment requirements for some v4l devices #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is usefull for devices where there are specific alignment requirements of the memory being written to by the V4L subsystem. One example where this is the case is the CSI-camera support Nvidia Tegra devices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there.
When using the userptr io-mode for V4L, the v4l driver can have special alignment requirements for the buffers that are given to it.
I hit this limitation by experimenting with the V4L2 drivers for CSI cameras on Nvidia Tegra devices.
This PR tries to allow for specifying custom allocators for the crate in a backward compatible way, and I thought it would be nice to contribute it back to upstream.
If there are any things you would like different, or require changes, please don't hesitate to mention it.
I was unsure where to base this change on, so I based it on the last released version of the crate. I see that
mainhas moved since then.Regards Morten