New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch 1 #6

Open

LukeMadhanga wants to merge 2 commits into raymondjavaxx:master from LukeMadhanga:patch-1

LukeMadhanga commented Jan 27, 2017

Used proper four character spacing
Introduced two new functions, getSwearWords and getSwearWordsByType

LukeMadhanga added 2 commits

January 27, 2017 16:01


          Two New Functions and Formatting

Can now see what the swear words were


          Function name error

e7d9683

Owner

raymondjavaxx commented Jan 30, 2017

Hi Luke,

Thanks for submitting the patch. I'm happy to merge this if you split the changes of 5712113 into two smaller/atomic commits.

Regarding the formatting, I agree with going from hard tabs to soft tabs, but I would like to keep the visibility declarations as per PSR-2.

-R

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment