Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement par_exact_chunks/_mut; slice chunks with exact size. #510

Closed
Kerollmops opened this issue Jan 20, 2018 · 5 comments
Closed

Implement par_exact_chunks/_mut; slice chunks with exact size. #510

Kerollmops opened this issue Jan 20, 2018 · 5 comments
Labels
enhancement parity-std

Comments

@Kerollmops
Copy link
Contributor

Kerollmops commented Jan 20, 2018 •
edited

As new methods as been added to the slice type. I propose the add of these new methods too.
These iterators seems to be really useful to llvm and its optimizations.

Here is the tracking issue for exact_chunks/_mut; slice chunks with exact size.
@Kerollmops Kerollmops changed the title Implement exact_chunks/_mut; slice chunks with exact size. Implement par_exact_chunks/_mut; slice chunks with exact size. Jan 20, 2018
@cuviper
Copy link
Member

cuviper commented Jan 24, 2018

(I labelled this parity-std::iter, but that's really std::slice -- maybe we need to use more labels...)

That addition sounds fine to me, but I'd prefer to wait for it to stabilize in std before we mimic it.

@zesterer
Copy link
Contributor

zesterer commented Jan 16, 2019 •
edited

poke

This is stable now. It would be awesome to see Rayon gain this feature. If help is needed, I'm willing to do the leg work.

@cuviper
Copy link
Member

cuviper commented Jan 17, 2019

Help is welcome, if this is a feature that interests you!

@zesterer zesterer mentioned this issue Jan 25, 2019
Merged
@sdroege
Copy link

sdroege commented Feb 5, 2019

Might also be interesting to have the rchunks_* iterators available from rayon in addition to this to have more API-equivalence between std and rayon

bors bot added a commit that referenced this issue Mar 12, 2020
@bors @zesterer @cuviper
Merge #629
3096967 
629: Implement chunks_exact and chunks_exact_mut r=cuviper a=zesterer

Follow-up PR from #510. `chunks_exact` (and its mutable counterpart) are not yet implemented on `ParallelIterator`, only `ParallelSlice`.

Co-authored-by: Joshua Barretto <joshua.s.barretto@gmail.com>
Co-authored-by: Josh Stone <cuviper@gmail.com>
@cuviper
Copy link
Member

cuviper commented Mar 12, 2020

I just merged #629 for par_chunks_exact/_mut and filed #734 for rchunks.

@cuviper cuviper closed this as completed Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement parity-std
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cuviper @sdroege @zesterer @Kerollmops