Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rayon has long had some logging functionality, but not well advertised.
The only mention is in the (private) module docs:
I, for one, have not "internally" used this for debugging at all, yet it
comes at some cost to all users, even disabled in release builds. At the
very least it requires
crossbeam-channel
that we're not using anywhereelse except tests. Besides that, this code also bloats the compiled size
of
rayon-core
by about 30%, and similar for its compile time.So let's just rip out the logger!
The remaining uses of
crossbeam-channel
in test cases are easilyavoidable too, since
std::sync::mpsc::Sender
is nowSync
.