Add find_first and find_last tests on a giant range
#362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuviper
commented
Jun 12, 2017
| // short-circuiting. We probably don't want testing to wait that long. ;) | ||
| // It would be nice if `find_last` could prioritize the later splits, | ||
| // basically flipping the `join` args, without needing indexed `rev`. | ||
| // (or could we have an unindexed `rev`?) |
There was a problem hiding this comment.
To some extent, this PR is really an RFC about this comment.
There was a problem hiding this comment.
About which part exactly? :)
Like, is there a way to make find_last prioritize the later splits?
There was a problem hiding this comment.
Right. I'd like this sort of thing to be usable even in a single-threaded "pool", and walking from start to end is a poor way to find the last match. I doubt it would come up often with absurd iterators like this, but it should be a good optimization to search roughly backwards in general.
There was a problem hiding this comment.
I see. That makes sense. I don't off hand know how best to do that though. =)
It's possible to generate giant iterators in Rayon, and these tests show that they can still be short-circuited properly in find operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to generate giant iterators in Rayon, and these tests show
that they can still be short-circuited properly in find operations.