Enable bors-ng #451
Merged
Enable bors-ng #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
Timed out |
We need to compare the `NTSTATUS` code, not `None` like on Unix.
|
I've now pruned pull-request CI down to just Linux 1.12 and nightly+unstable, for faster feedback and to reduce queue delays (especially from the overburdened OSX). We should still get full Travis and Appveyor test results when bors pushes to its branches. bors r+ |
ghost
mentioned this pull request
bors bot
added a commit
to crossbeam-rs/crossbeam
that referenced
this pull request
Nov 5, 2018
213: Enable bors-ng r=stjepang a=stjepang Using bors has multiple benefits: * It streamlines PR approval process: just say "bors r+" and it will be tested & merged. We can also delegate permission to approve PRs, which means there will be less ping-ponging between reviewers. * Once approved, the PR is automatically tested and merged into master. Note that it will be tested only once, while currently we test it twice (before the merge and after merge). * It'll make it easier to reduce CI build times: https://github.com/rayon-rs/rayon/blob/8c05d2b8788dc64067d6e79ff3b3cfe90a5e249e/.travis.yml#L11-L13 See how Rayon uses bors-ng: rayon-rs/rayon#451 Quick intro: https://bors.tech/documentation/getting-started/ Co-authored-by: Stjepan Glavina <stjepang@gmail.com>
bors bot
added a commit
to crossbeam-rs/crossbeam
that referenced
this pull request
Nov 5, 2018
213: Enable bors-ng r=stjepang a=stjepang Using bors has multiple benefits: * It streamlines PR approval process: just say "bors r+" and it will be tested & merged. We can also delegate permission to approve PRs, which means there will be less ping-ponging between reviewers. * Once approved, the PR is automatically tested and merged into master. Note that it will be tested only once, while currently we test it twice (before the merge and after merge). * It'll make it easier to reduce CI build times: https://github.com/rayon-rs/rayon/blob/8c05d2b8788dc64067d6e79ff3b3cfe90a5e249e/.travis.yml#L11-L13 See how Rayon uses bors-ng: rayon-rs/rayon#451 Quick intro: https://bors.tech/documentation/getting-started/ Co-authored-by: Stjepan Glavina <stjepang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.