Skip to content

/rayon

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable bors-ng #451

Merged
merged 5 commits into from Oct 6, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@cuviper
@cuviper
Copy link
Member

cuviper commented Oct 6, 2017

No description provided.

@cuviper
Enable bors-ng
Loading status checks…
6004460
@cuviper

This comment has been minimized.

Sign in to view
Copy link
Member Author

cuviper commented Oct 6, 2017

bors r+

bors bot added a commit that referenced this pull request Oct 6, 2017

@bors
Merge #451 
451: Enable bors-ng r=cuviper a=cuviper
Loading status checks…
9507a21
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors bot commented Oct 6, 2017

Timed out

cuviper added some commits Oct 6, 2017

@cuviper
CI fast_finish: true
8b6a980
@cuviper
Fix Windows tests/run-pass/stack_overflow_crash.rs 
We need to compare the `NTSTATUS` code, not `None` like on Unix.
e10f74a
@cuviper
Try using travis conditionals
Loading status checks…
d1b8b1c
@cuviper
Let bors wait a long time for OSX
Loading status checks…
320a4d0
@cuviper

This comment has been minimized.

Sign in to view
Copy link
Member Author

cuviper commented Oct 6, 2017

I've now pruned pull-request CI down to just Linux 1.12 and nightly+unstable, for faster feedback and to reduce queue delays (especially from the overburdened OSX). We should still get full Travis and Appveyor test results when bors pushes to its branches.

bors r+

bors bot added a commit that referenced this pull request Oct 6, 2017

@bors
Merge #451 
451: Enable bors-ng r=cuviper a=cuviper
Loading status checks…
4751759
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors bot commented Oct 6, 2017

Build succeeded

@bors bors bot merged commit 320a4d0 into rayon-rs:master Oct 6, 2017
2 checks passed

2 checks passed

bors Build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cuviper cuviper deleted the cuviper:bors branch Oct 12, 2017

@stjepang stjepang referenced this pull request Nov 5, 2018

Merged

Enable bors-ng #213

bors bot added a commit to crossbeam-rs/crossbeam that referenced this pull request Nov 5, 2018

@bors @stjepang
Merge #213 
213: Enable bors-ng r=stjepang a=stjepang

Using bors has multiple benefits:

* It streamlines PR approval process: just say "bors r+" and it will be tested & merged. We can also delegate permission to approve PRs, which means there will be less ping-ponging between reviewers.

* Once approved, the PR is automatically tested and merged into master. Note that it will be tested only once, while currently we test it twice (before the merge and after merge).

* It'll make it easier to reduce CI build times: https://github.com/rayon-rs/rayon/blob/8c05d2b8788dc64067d6e79ff3b3cfe90a5e249e/.travis.yml#L11-L13

See how Rayon uses bors-ng: rayon-rs/rayon#451
Quick intro: https://bors.tech/documentation/getting-started/

Co-authored-by: Stjepan Glavina <stjepang@gmail.com>
Loading status checks…
6e4a9a5

bors bot added a commit to crossbeam-rs/crossbeam that referenced this pull request Nov 5, 2018

@bors @stjepang
Merge #213 
213: Enable bors-ng r=stjepang a=stjepang

Using bors has multiple benefits:

* It streamlines PR approval process: just say "bors r+" and it will be tested & merged. We can also delegate permission to approve PRs, which means there will be less ping-ponging between reviewers.

* Once approved, the PR is automatically tested and merged into master. Note that it will be tested only once, while currently we test it twice (before the merge and after merge).

* It'll make it easier to reduce CI build times: https://github.com/rayon-rs/rayon/blob/8c05d2b8788dc64067d6e79ff3b3cfe90a5e249e/.travis.yml#L11-L13

See how Rayon uses bors-ng: rayon-rs/rayon#451
Quick intro: https://bors.tech/documentation/getting-started/

Co-authored-by: Stjepan Glavina <stjepang@gmail.com>
Loading status checks…
b634251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.