Bug - llGetSubString and llList2List make wrong result on negative out of range index (when Optimizations are enabled)

[PellSmit]

(1)

// OutOfRangeNegativeIndex.lslp
default
{
	state_entry()
	{
		string s = llGetSubString("0123456789", -11, -11);
		llOwnerSay("s = " + s + ", length = " + (string)llStringLength(s));
		list l = llList2List([0, 1, 2, 3, 4, 5, 6, 7, 8, 9], -11, -11);
		llOwnerSay("l = [" + llDumpList2String(l, ", ") + "]");
	}
}

was converted to

(2)

// OutOfRangeNegativeIndex.lslp 
// 2016-11-11 13:40:30 - LSLForge (0.1.9) generated
// OutOfRangeNegativeIndex.lslp
default {

	state_entry() {
    string s = "0";
    llOwnerSay(((("s = " + s) + ", length = ") + ((string)llStringLength(s))));
    list l = [0];
    llOwnerSay((("l = [" + llDumpList2String(l,", ")) + "]"));
  }
}

But result of (1) is:
[20:31] Object: s = , length = 0
[20:31] Object: l = []

and (2)
[20:32] Object: s = 0, length = 1
[20:32] Object: l = [0]

It is a bug in InternalLLFuncs.hs

[raysilent]

Pell if you rollback InternalLLFuncs.hs to it's previous version will it fix the bug?

[PellSmit]

Do you mean rollback to 0.1.8?

[raysilent]

See here, the last time we updated it was October 20th

https://github.com/raysilent/lslforge/commits/master/lslforge/haskell/src/Language/Lsl/Internal/InternalLLFuncs.hs

[PellSmit]

Tried it but same result...

[raysilent]

It must be somewhere here:

subList source start end =
    let n = length source
        s = convertIndex n start
        e = convertIndex n end
    in
        if s <= e then take (e - s + 1) $ drop s source
        else take (e+1) source ++ drop s source

convertIndex length index = if index < 0 then length + index else index

[PellSmit]

Yes, exactly!
I'll fix it later.

[raysilent]

It works with the indecies -1..-10, and then keeps returning the same -10 index

[raysilent]

Looks good! Merged everything into https://github.com/raysilent/lslforge/tree/0.1.9.1 branch