Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: volume mount files via app helm chart #109

Closed
wants to merge 9 commits into from
Closed

Conversation

anujk14
Copy link
Contributor

@anujk14 anujk14 commented Jan 15, 2024

This PR adds functionality to create configmaps from files and volume mount them. This is a common use case when for applications that read their configs from a particular file or path in the deployment.

@anujk14 anujk14 changed the title feat: Volume mount files via app helm chart feat: volume mount files via app helm chart Jan 16, 2024
@@ -165,3 +165,9 @@ autoscaling:
maxReplicas: 2
targetMemory: 80
targetCPU: 80

mount:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets comment this in values.yaml

@rohilsurana
Copy link
Member

version bump needed

@anujk14
Copy link
Contributor Author

anujk14 commented Jan 17, 2024

Closing this as it is no longer required. Current volumeMounts functionality serves the same purpose.

@anujk14 anujk14 closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants