-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce grant entity #249
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and updating approval
…access instead of appeal
rahmatrhd
force-pushed
the
decouple-appeal-access
branch
from
August 16, 2022 06:06
28c8929
to
fc08844
Compare
Pull Request Test Coverage Report for Build 2916385434
💛 - Coveralls |
rahmatrhd
requested review from
mabdh,
Chief-Rishab,
bsushmith and
singhvikash11
August 16, 2022 09:52
62 files 😮 |
mabdh
reviewed
Aug 16, 2022
mabdh
reviewed
Aug 16, 2022
Can we please specify, what things that could break and what things that should do to acomodate this changes? |
mabdh
approved these changes
Aug 24, 2022
@rahmatrhd @mabdh We can merge this. But based on how the decision goes for #171, we should think of the right name for this entity. I think |
haveiss
pushed a commit
that referenced
this pull request
Oct 21, 2022
* feat: introduce access entity * chore: handle access creation on creating appeal (with auto approval) and updating approval * chore: add role field in access and filter by permissions in List * chore: validate appeal extension using existing active access * chore: change provider service signature for grant/revoke to receive access instead of appeal * chore: update error message * feat: add access revoke and bulk revoke API * test: fix test cases * chore: add null check for access.Appeal * refactor: rename isEligibleToExtend to checkExtensionEligibility * fix: fix gorm annotation for ID field * feat: add list user accesses api * refactor: add nil checking in ToAccessProto * fix: fix ToAccessProto usage * refactor: remove unnecessary boolean return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release 1 for #246
Checklist
appeal
status toterminated
)appeal
status toterminated
)access
status toinactive
when revoking appeal