Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bigquery): upgrade client to support authorized UDFs #343

Merged
merged 1 commit into from
Jan 16, 2023
Merged

fix(bigquery): upgrade client to support authorized UDFs #343

merged 1 commit into from
Jan 16, 2023

Conversation

haveiss
Copy link
Contributor

@haveiss haveiss commented Jan 12, 2023 •
edited

Context

  • Currently guardian using cloud.google.com/go/bigquery which doesn't support authorized UDFs

Impact

  • When authorized appeal to dataset that have authorized UDFs, it will throw an error bigquery: invalid access value

Changes

@coveralls
Copy link

coveralls commented Jan 12, 2023 •
edited

Pull Request Test Coverage Report for Build 3927048063

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.561%
Totals Coverage Status
Change from base Build 3909370449: 0.0%
Covered Lines: 7357
Relevant Lines: 10139
💛 - Coveralls

@haveiss haveiss merged commit 975af99 into main Jan 16, 2023
@haveiss haveiss deleted the fix/upgrade-bigquery-client branch January 16, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabdh mabdh mabdh approved these changes

@StewartJingga StewartJingga StewartJingga approved these changes

@ravisuhag ravisuhag Awaiting requested review from ravisuhag ravisuhag is a code owner

@rahmatrhd rahmatrhd Awaiting requested review from rahmatrhd rahmatrhd is a code owner

@AkarshSatija AkarshSatija Awaiting requested review from AkarshSatija AkarshSatija is a code owner

@bsushmith bsushmith Awaiting requested review from bsushmith bsushmith is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@haveiss @coveralls @mabdh @StewartJingga