Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: frontier provider and add api documentation #395

Merged
merged 6 commits into from
Nov 20, 2023
Merged

refactor: frontier provider and add api documentation #395

merged 6 commits into from
Nov 20, 2023

Conversation

Chief-Rishab
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Nov 15, 2023 •
edited by github-actions bot
Loading

Pull Request Test Coverage Report for Build 6923002535

  • 107 of 119 (89.92%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 73.832%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/providers/frontier/client.go 75 87 86.21%
Totals Coverage Status
Change from base Build 6919174852: -0.04%
Covered Lines: 8673
Relevant Lines: 11747
💛 - Coveralls

kushsharma
kushsharma reviewed Nov 19, 2023
View reviewed changes
Copy link
Member

@kushsharma kushsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than minor comments, LGTM

@ravisuhag ravisuhag merged commit cf1c665 into main Nov 20, 2023
5 checks passed
@ravisuhag ravisuhag deleted the refactor-shield branch November 20, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushsharma kushsharma kushsharma approved these changes

@ravisuhag ravisuhag Awaiting requested review from ravisuhag ravisuhag is a code owner

@rahmatrhd rahmatrhd Awaiting requested review from rahmatrhd rahmatrhd is a code owner

@AkarshSatija AkarshSatija Awaiting requested review from AkarshSatija AkarshSatija is a code owner

@mabdh mabdh Awaiting requested review from mabdh mabdh is a code owner

@bsushmith bsushmith Awaiting requested review from bsushmith bsushmith is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Chief-Rishab @coveralls @kushsharma @ravisuhag