fix: replay manual job and timeout issue (#767)

* fix: ignore job that does not have schedule from replay tree Co-authored-by: Sandeep Bhardwaj <sandeep.bhardwaj@gojek.com> * chore: increase write and idle server timeout Co-authored-by: Sandeep Bhardwaj <sandeep.bhardwaj@gojek.com> --------- Co-authored-by: Sandeep Bhardwaj <sandeep.bhardwaj@gojek.com>
raystack · Mar 29, 2023 · 4ab86f0 · 4ab86f0
1 parent 1dd694e
commit 4ab86f0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/job/replay.go b/job/replay.go
@@ -110,6 +110,9 @@ func findOrCreateDAGNode(dagTree *tree.MultiRootTree, dagSpec models.JobSpec) *t
 func populateDownstreamRuns(parentNode *tree.TreeNode) (*tree.TreeNode, error) {
 	for idx, childNode := range parentNode.Dependents {
 		childDag := childNode.Data.(models.JobSpec)
+		if childDag.Schedule.Interval == "" {
+			continue
+		}
 		taskSchedule, err := cron.ParseCronSchedule(childDag.Schedule.Interval)
 		if err != nil {
 			return nil, err

diff --git a/server/server.go b/server/server.go
@@ -169,8 +169,8 @@ func prepareHTTPProxy(grpcAddr string, grpcServer *grpc.Server) (*http.Server, f
 		Handler:      grpcHandlerFunc(grpcServer, baseMux),
 		Addr:         grpcAddr,
 		ReadTimeout:  5 * time.Second,
-		WriteTimeout: 60 * time.Second,
-		IdleTimeout:  120 * time.Second,
+		WriteTimeout: 30 * time.Minute,
+		IdleTimeout:  5 * time.Minute,
 	}
 
 	return srv, cleanup, nil