Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : add external http sensor at optimus #150

Merged
merged 12 commits into from
Feb 28, 2022
Merged

feat : add external http sensor at optimus #150

merged 12 commits into from
Feb 28, 2022

Conversation

siddhanta-rath
Copy link
Member

@siddhanta-rath siddhanta-rath mentioned this pull request Feb 14, 2022
Closed
@siddhanta-rath siddhanta-rath self-assigned this Feb 14, 2022
@coveralls
Copy link

coveralls commented Feb 16, 2022 •
edited

Pull Request Test Coverage Report for Build 1910087129

  • 55 of 65 (84.62%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 72.606%
Changes Missing Coverage Covered Lines Changed/Added Lines %
api/handler/v1beta1/adapter.go 23 27 85.19%
store/local/job_spec_adapter.go 32 38 84.21%
Totals Coverage Status
Change from base Build 1906341684: 0.2%
Covered Lines: 5179
Relevant Lines: 7133
💛 - Coveralls

@siddhanta-rath siddhanta-rath changed the title [WIP] feat : add external http sensor at optimus feat : add external http sensor at optimus Feb 18, 2022
@sbchaos sbchaos linked an issue Feb 27, 2022 that may be closed by this pull request
Support for External Sensor for Optimus Jobs #138
Closed
sravankorumilli
sravankorumilli requested changes Feb 27, 2022
View reviewed changes
store/local/job_spec_adapter.go Outdated Show resolved Hide resolved
api/handler/v1beta1/adapter.go Outdated Show resolved Hide resolved
ext/scheduler/airflow/resources/__lib.py Outdated Show resolved Hide resolved
ext/scheduler/airflow/resources/base_dag.py Show resolved Hide resolved
ext/scheduler/airflow2/resources/__lib.py Outdated Show resolved Hide resolved
store/local/job_spec_adapter.go Outdated Show resolved Hide resolved
sravankorumilli
sravankorumilli approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@sravankorumilli sravankorumilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siddhanta-rath siddhanta-rath merged commit ed76281 into main Feb 28, 2022
@siddhanta-rath siddhanta-rath deleted the external-http-sensor branch February 28, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sravankorumilli sravankorumilli sravankorumilli approved these changes

Assignees

@siddhanta-rath siddhanta-rath

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for External Sensor for Optimus Jobs
3 participants
@siddhanta-rath @coveralls @sravankorumilli