feat: replay config overriding #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4530217611
💛 - Coveralls |
arinda-arif
requested changes
Mar 27, 2023
deryrahman
force-pushed
the
feature/replay-config
branch
from
186df17
to
452547c
Compare
deryrahman
force-pushed
the
feature/replay-config
branch
from
88449b7
to
9a20bab
Compare
arinda-arif
approved these changes
Mar 27, 2023
arinda-arif
added a commit
that referenced
this pull request
Mar 27, 2023
* feat: add replay entity and repository * feat: add replay service * feat: add replay handler * feat: add replay manager and worker * test: fix job run service and replay service test cases * test: fix scheduler status test case * refactor: add JobReplayRunService in ReplayWorker * refactor: fix lint issues * refactor: remove logical time from JobRunStatus * feat: implement UpdateReplay in repository * refactor: fetch a single replay request to be processed * refactor: change implementation of GetReplayToExecute * refactor: update replay state to in progress once it is picked * refactor: pass job cron value to replay validate * feat: implement replay validator * refactor: change replay entity structure * refactor: validator to accept replay request * feat: implement GetReplayRequestsByStatus * fix: GetReplayRequestByStatus invalid query * feat: add replay timeout in server config * refactor: update replay and update replay status in repository * feat: add replay time out check * refactor: remove replay id from ReplayWithRun * feat: add replay create cli * refactor: unexport replay entity fields * fix: resolve migration files conflict * test: add replay entity unit tests * feat: add replay loop timeout in server config * fix: replay repository to return scheduled time in utc * fix: unable to process sequential replay properly issue * fix: error log in replay service * feat: register replay to optimus server * chore: add todos in replay worker * refactor: remove replay's worker and loop timeout configuration * chore: reduce replay create client timeout from 1 hour to 1 minute * fix: log level, log message and replay message * refactor: reword error message when unable to parse cron interval * fix: add missing description flag in replay create * refactor: rename var and simplify processing new replay in replay worker * refactor: remove start and end time index in replay request table * chore: add note and todo in scheduler status and replay repository * fix: update conflicted migration files number * chore: fix lint issues * chore: remove unnecessary error not found catch in replay repository * fix: issue when replay worker unable to get job details and add more tests * test: add more replay test cases * chore: fix lint issue * test: add replay manager unit tests * test: add scheduler BC status unit tests * feat: replay config overriding (#765) * feat: support replay job config proton * feat: add flag for replay job config * feat: add job config on the replay * feat: adding job replay repo placeholder * feat: implement job replay repo * fix: get replay config by tenant and job name * refactor: rename get replay job config * refactor: avoid magic number * fix: linter * fix: query for get replay job config * chore: update proton commit * fix: issue on replay creation when job config is not set --------- Co-authored-by: Dery Rahman Ahaddienata <dery.ra@gmail.com>
arinda-arif
added a commit
to goto/optimus
that referenced
this pull request
Mar 27, 2023
* feat: add replay entity and repository * feat: add replay service * feat: add replay handler * feat: add replay manager and worker * test: fix job run service and replay service test cases * test: fix scheduler status test case * refactor: add JobReplayRunService in ReplayWorker * refactor: fix lint issues * refactor: remove logical time from JobRunStatus * feat: implement UpdateReplay in repository * refactor: fetch a single replay request to be processed * refactor: change implementation of GetReplayToExecute * refactor: update replay state to in progress once it is picked * refactor: pass job cron value to replay validate * feat: implement replay validator * refactor: change replay entity structure * refactor: validator to accept replay request * feat: implement GetReplayRequestsByStatus * fix: GetReplayRequestByStatus invalid query * feat: add replay timeout in server config * refactor: update replay and update replay status in repository * feat: add replay time out check * refactor: remove replay id from ReplayWithRun * feat: add replay create cli * refactor: unexport replay entity fields * fix: resolve migration files conflict * test: add replay entity unit tests * feat: add replay loop timeout in server config * fix: replay repository to return scheduled time in utc * fix: unable to process sequential replay properly issue * fix: error log in replay service * feat: register replay to optimus server * chore: add todos in replay worker * refactor: remove replay's worker and loop timeout configuration * chore: reduce replay create client timeout from 1 hour to 1 minute * fix: log level, log message and replay message * refactor: reword error message when unable to parse cron interval * fix: add missing description flag in replay create * refactor: rename var and simplify processing new replay in replay worker * refactor: remove start and end time index in replay request table * chore: add note and todo in scheduler status and replay repository * fix: update conflicted migration files number * chore: fix lint issues * chore: remove unnecessary error not found catch in replay repository * fix: issue when replay worker unable to get job details and add more tests * test: add more replay test cases * chore: fix lint issue * test: add replay manager unit tests * test: add scheduler BC status unit tests * feat: replay config overriding (raystack#765) * feat: support replay job config proton * feat: add flag for replay job config * feat: add job config on the replay * feat: adding job replay repo placeholder * feat: implement job replay repo * fix: get replay config by tenant and job name * refactor: rename get replay job config * refactor: avoid magic number * fix: linter * fix: query for get replay job config * chore: update proton commit * fix: issue on replay creation when job config is not set --------- Co-authored-by: Dery Rahman Ahaddienata <dery.ra@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.