Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update package names #34

Merged
merged 3 commits into from
May 17, 2022
Merged

Conversation

ramey
Copy link
Member

@ramey ramey commented May 17, 2022

Change package names throughout Raccoon to more standard naming, which includes directory/user

Eg - raccoon/config -> github.com/odpf/raccoon

Signed-off-by: ramey rameygirdhar@gmail.com

Signed-off-by: ramey <rameygirdhar@gmail.com>
@ramey ramey linked an issue May 17, 2022 that may be closed by this pull request
Signed-off-by: ramey <rameygirdhar@gmail.com>
Copy link
Contributor

@chakravarthyvp chakravarthyvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chakravarthyvp
Copy link
Contributor

Signed-off-by: ramey [rameygirdhar@gmail.com](mailto:rameygirdhar@gmail.com)

Why do we need this sign-off? Is it part of our template?

Signed-off-by: ramey <rameygirdhar@gmail.com>
@ramey
Copy link
Member Author

ramey commented May 17, 2022

Signed-off-by: ramey [rameygirdhar@gmail.com](mailto:rameygirdhar@gmail.com)

Why do we need this sign-off? Is it part of our template?

@chakravarthyvp It's just something I am used to doing, seen this in a lot of Open source projects. Do we have any template as such?

@chakravarthyvp
Copy link
Contributor

@chakravarthyvp It's just something I am used to doing, seen this in a lot of Open source projects. Do we have any template as such?

You can refer here. We follow conventional commits and don't need explicit sign-off.
https://github.com/odpf/raccoon/blob/main/docs/contribute/development.md

@chakravarthyvp chakravarthyvp merged commit a69eb58 into raystack:main May 17, 2022
@ramey ramey deleted the standardisation branch May 24, 2022 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make raccoon imports standardized
2 participants