fix: config parsing backward compatibility for time.Duration #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushsharma
changed the title
kushsharma
force-pushed
the
config-backward-compatibility
branch
2 times, most recently
from
e7677f8
to
5ec2eaf
Compare
In last release, mapstructure decode overrides were introduced but by default they were overriding the viper(library we use for config parsing) options of mapstructure decoding. Adding those options back would make this change backward compatible. For example, in shield this is causing failure in parsing "10m" as time.Duration type Signed-off-by: Kush Sharma <thekushsharma@gmail.com>
kushsharma
force-pushed
the
config-backward-compatibility
branch
from
5ec2eaf
to
5cf49a5
Compare
kushsharma
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In last release, mapstructure decode overrides were introduced but by default, they were overriding the viper(library we use for config parsing) options of mapstructure decoding. Adding those options back would make this change backward compatible.
For example, in shield this is causing failure in parsing
10mastime.Durationtype