Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laundry list of improvements #38

Closed
whoAbhishekSah opened this issue Jul 30, 2021 · 4 comments
Closed

Laundry list of improvements #38

whoAbhishekSah opened this issue Jul 30, 2021 · 4 comments
Labels
good first issue Good for newcomers
Projects
Roadmap 2021 H2

Comments

@whoAbhishekSah
Copy link
Member

whoAbhishekSah commented Jul 30, 2021 •
edited
Loading

This is a running list of possible code improvements.

  1. File naming convention in api/handlers directory. Some files are singular names and some are plural names.
  2. Router is bloated with all endpoints, can we namespace the routes in separate router files and include all of them in a top-level/top-tier router?
  3. Moving request validation from handlers to domain Example Commit: 2ae3bce
  4. Add test coverage info in readme
@whoAbhishekSah
Copy link
Member Author

@pyadav for your reference.

@ravisuhag
Copy link
Member

ravisuhag commented Jul 30, 2021 •
edited
Loading

@whoAbhishekSah FYI, We are thinking of moving to GRPC in upcoming version.

@whoAbhishekSah whoAbhishekSah added the good first issue Good for newcomers label Aug 10, 2021
@burntcarrot
Copy link

@whoAbhishekSah I'd like to take this as I'm actively working on moving the request validation to domain. Could you assign me to this issue?

@Jedi18 Jedi18 mentioned this issue Aug 15, 2021
Closed
@ravisuhag ravisuhag linked a pull request Aug 15, 2021 that will close this issue
refactor: move request validation from handlers to domain #47
Closed
@ravisuhag ravisuhag added this to To do in Roadmap 2021 H2 Oct 7, 2021
@ravisuhag ravisuhag moved this from To do to Planned in Roadmap 2021 H2 Nov 26, 2021
@ravisuhag
Copy link
Member

This issue is covered as part of moving to GRPC.

@ravisuhag ravisuhag moved this from Planned to Done in Roadmap 2021 H2 Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
No open projects
Roadmap 2021 H2
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: move request validation from handlers to domain Jedi18/siren
3 participants
@ravisuhag @whoAbhishekSah @burntcarrot