refactor: move request validation from handlers to domain #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyadav
force-pushed
the
main
branch
3 times, most recently
from
c3f6a34
to
3fc03b2
Compare
|
@Jedi18 Siren has moved to GRPC instead of HTTP. So, I am closing this PR. Would love to see more continuous contributions from you in the future. |
|
Thanks for letting me know! I'll try my hand at the other issues (or the other repos) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move request validation of alertmanager, rules and templates from handlers to domain.
Issue #38