Preparando revisão do código #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neaar3
commented
Apr 27, 2022
| return res.status(422).send(error.message); | ||
| break; | ||
| } | ||
| console.log(error); |
There was a problem hiding this comment.
cuidado com console.log no código 👀
Comment on lines
-87
to
-130
| function generateUniqueCardNumber() { | ||
| return faker.finance.creditCardNumber("mastercard"); | ||
| } | ||
| async function generateCardholderName(employeeId: number) { | ||
| const employee = await employeeRepository.findById(employeeId); | ||
| const name = employee.fullName; | ||
| const names = name.split(" "); | ||
| const meio = new Array(); | ||
|
|
||
| for (let i = 1; i < names.length - 1; i++) { | ||
| if (names[i].length >= 3) { | ||
| meio.push(name[i][0]); | ||
| } | ||
| } | ||
| const finalName = [names[0], meio, names[names.length - 1]]; | ||
|
|
||
| return finalName.join(" ").toUpperCase(); | ||
| } | ||
| function defineExpirationDate() { | ||
| return dayjs(Date.now()).add(5, "year").format("MM-YY"); | ||
| } | ||
| function generateEncriptedCVC() { | ||
| const CVC = faker.finance.creditCardCVV(); | ||
| return bcrypt.hashSync(CVC, 10); | ||
| } | ||
| async function generateCardData(employeeId: number, type: TransactionTypes) { | ||
| const cardNumber = generateUniqueCardNumber(); | ||
| const cardHolderName = await generateCardholderName(employeeId); | ||
| const expirationDate = defineExpirationDate(); | ||
| const encryptedCVC = generateEncriptedCVC(); | ||
| const cardData = { | ||
| employeeId, | ||
| number: cardNumber, | ||
| cardHolderName, | ||
| securityCode: encryptedCVC, | ||
| expirationDate, | ||
| password: null, | ||
| isVirtual: true, | ||
| originalCardId: null, | ||
| isBlocked: true, | ||
| type, | ||
| }; | ||
| return cardData; | ||
| } |
There was a problem hiding this comment.
Maior parte dessas funções poderia estar em uma utils de cartão. Deixaria a service mais limpa e focada no que ela precisa atuar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.