Skip to content

Commit

Permalink
build: Adopt rotated GH token. (#283)
Browse files Browse the repository at this point in the history
* build: Adopt rotated GH token.

* chore: npm audit fix

* build: Exempt tough-cookie vulnerability from audit-ci
  • Loading branch information
adamkingit committed Jul 10, 2023
1 parent c1bfa76 commit 02e0a5c
Show file tree
Hide file tree
Showing 4 changed files with 130 additions and 106 deletions.
3 changes: 3 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ node_js:
services:
- docker

global:
- GITHUB_TOKEN="${PUBLIC_GITHUB_TOKEN_2023_07_10}"

before_install:
- echo "$DOCKERHUB_TOKEN" | docker login -u "icdevops" --password-stdin

Expand Down
11 changes: 9 additions & 2 deletions audit-ci.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,18 @@
"details": "The Request package through 2.88.2 for Node.js allows a bypass of SSRF mitigations via an attacker-controller server that does a cross-protocol redirect (HTTP to HTTPS, or HTTPS to HTTP)",
"justification1": "Request package is deprecated and unlikely to receive updates.",
"justification2": "Application unaffected as it only uses request by way of kubernetes/client-node, which talks to kubernetes, which can be asserted as not an attacker-controlled server.",
"expiry": "28 April 2023 00:00"
"expiry": "31 July 2023 00:00"
},
{
"advisory": "GHSA-72xf-g2v4-qvf3",
"details": "Versions of the package tough-cookie before 4.1.3 are vulnerable to Prototype Pollution due to improper handling of Cookies when using CookieJar in rejectPublicSuffixes=false mode. This issue arises from the manner in which the objects are initialized.",
"justification1": "Package used by request, which is also exempted. Explicitly freezeing Object to guarantee attack vector is inaccessible.",
"expiry": "31 July 2023 00:00"
}
],
"allowlist": [
"GHSA-p8p7-x288-28g6"
"GHSA-p8p7-x288-28g6",
"GHSA-72xf-g2v4-qvf3"
],
"skip-dev": true
}
Loading

0 comments on commit 02e0a5c

Please sign in to comment.