Skip to content

Commit

Permalink
replace request with axios (#278)
Browse files Browse the repository at this point in the history
Co-authored-by: ethanstjohn <ethanstjohn@ibm.com>
  • Loading branch information
ethanstjohn and ethanstjohn committed Apr 13, 2023
1 parent 73247f9 commit a1f1e41
Show file tree
Hide file tree
Showing 3 changed files with 955 additions and 814 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ before_install:

script:
# Audit npm packages. Fail build whan a PR audit fails, otherwise report the vulnerability and proceed.
- if [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then npm audit; else npm audit || true; fi
- if [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then npx audit-ci --config audit-ci.json; else npx audit-ci --config audit-ci.json || true; fi
- npm run lint
- npm run snifftest
- if [[ "${TRAVIS_TAG}" =~ ^[0-9]+\.[0-9]+\.[0-9]+(-rc\.[0-9]+)?$ ]]; then npm version --no-git-tag-version "${TRAVIS_TAG}"; fi
Expand Down
16 changes: 16 additions & 0 deletions audit-ci.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"low": true,
"_allowlistInfo": [
{
"advisory": "GHSA-p8p7-x288-28g6",
"details": "The Request package through 2.88.2 for Node.js allows a bypass of SSRF mitigations via an attacker-controller server that does a cross-protocol redirect (HTTP to HTTPS, or HTTPS to HTTP)",
"justification1": "Request package is deprecated and unlikely to receive updates.",
"justification2": "Application unaffected as it only uses request by way of kubernetes/client-node, which talks to kubernetes, which can be asserted as not an attacker-controlled server.",
"expiry": "28 April 2023 00:00"
}
],
"allowlist": [
"GHSA-p8p7-x288-28g6"
],
"skip-dev": true
}
Loading

0 comments on commit a1f1e41

Please sign in to comment.