Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag support for subscriptions and service subscriptions #1318

Merged
merged 19 commits into from
May 9, 2023

Conversation

carrolp
Copy link
Contributor

@carrolp carrolp commented May 4, 2023

  • Add support to create and edit subscriptions and serviceSubscriptions with tags (arrays of strings, like for Channels)
  • Add support to query subscriptions and service subscriptions by matching tags, and to include tags in results
  • Unit tests

@carrolp carrolp marked this pull request as ready for review May 5, 2023 13:17
@carrolp carrolp marked this pull request as draft May 5, 2023 19:46
@carrolp carrolp marked this pull request as ready for review May 5, 2023 20:46
adamkingit
adamkingit previously approved these changes May 8, 2023
@carrolp carrolp requested a review from adamkingit May 9, 2023 13:55
@carrolp carrolp merged commit 267e720 into master May 9, 2023
2 checks passed
@carrolp carrolp deleted the subscription-tags-20230504 branch May 9, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants