Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Usability Automatically Update The Config Map For GHE #200

Closed
daniel-butler-irl opened this issue Jan 16, 2020 · 0 comments · Fixed by #317
Closed

Improve Usability Automatically Update The Config Map For GHE #200

daniel-butler-irl opened this issue Jan 16, 2020 · 0 comments · Fixed by #317
Assignees
@dalehille
Labels
enhancement New feature or request

Comments

@daniel-butler-irl
Copy link

Is your feature request related to a problem? Please describe.
Currently, when configuring GHE I enter the settings on the Razeedash through the UI. There is then a manual step to add the github_url and github_api which I just provided to the Configmap. If you do not update the Configmap you get logged in and it looks like it is working. I guess this also applies to Bitbucket but have not used that.

Describe the solution you'd like
Automatically update the Configmap with the github_url and github_api.

Describe alternatives you've considered
If this is not technically possible, then add text to the GHE prompt to say additional steps are required to complete the configuration and link back to the documentation.

Additional context
I was following the main tutorial https://github.com/razee-io/Razee and did not realize I needed to read more documentation in Razeedash repo to make it work. It took me 30 mins before I figured it out. This is not very user-friendly and does not give a good first impression to a new user when evaluating.
@daniel-butler-irl daniel-butler-irl changed the title Improve Usability Automatacly Update The Config Map For GHE Improve Usability Automatically Update The Config Map For GHE Jan 16, 2020
@adamkingit adamkingit added the enhancement New feature or request label Jan 17, 2020
@dalehille dalehille self-assigned this Jun 12, 2020
dalehille added a commit that referenced this issue Jun 12, 2020
@dalehille
Fix: updates to accounts-ghe (fixes #201 , #200 )
27b5d01 
- Make accounts-ghe a local package
- don't send auth token to github as part of params
- don't require GITHUB_API and GITHUB_URL for ghe logins
- sanitize GHE url input on the initial razeedash configuration screen
@dalehille dalehille mentioned this issue Jun 13, 2020
Merged
mckaymic pushed a commit that referenced this issue Jun 16, 2020
@dalehille
Fix: updates to accounts-ghe (fixes #201 , #200) (#317)
39faece 
* Fix: updates to accounts-ghe (fixes #201 , #200 )

- Make accounts-ghe a local package
- don't send auth token to github as part of params
- don't require GITHUB_API and GITHUB_URL for ghe logins
- sanitize GHE url input on the initial razeedash configuration screen

* add packages/accounts-ghe

* Update packages

* modernize accounts-ghe and make it a local package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dalehille dalehille

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: updates to accounts-ghe (fixes #201 , #200) razee-io/Razeedash
3 participants
@dalehille @adamkingit @daniel-butler-irl