Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress issues: "Completed" label is too clingy #304

Closed
jellodiil opened this issue Feb 16, 2020 · 8 comments
Closed

Progress issues: "Completed" label is too clingy #304

jellodiil opened this issue Feb 16, 2020 · 8 comments
Labels
backend An issue with the API bug Something isn't working
Projects

Comments

@jellodiil
Copy link
Contributor

Progress doesn't change: if rewatching video, tick does get removed, but course still labeled "Completed"..
(It has now eventually updated.. but it took a long time.. Sometimes switching between pages works, but it chilled there in progress but labeled "Completed" for many minutes.)

1x photo in Testflight

@jellodiil jellodiil added the bug Something isn't working label Feb 16, 2020
@jellodiil jellodiil added this to To do in v1.0 via automation Feb 16, 2020
@sammyd
Copy link
Collaborator

sammyd commented Feb 16, 2020

image

@sammyd sammyd moved this from To do to In progress in v1.0 Feb 17, 2020
@sammyd sammyd moved this from In progress to Ready for Review in v1.0 Feb 18, 2020
@sammyd sammyd moved this from Ready for Review to Out for Review in v1.0 Feb 19, 2020
@jellodiil
Copy link
Contributor Author

Updates immediately now.

v1.0 automation moved this from Out for Review to Done Feb 22, 2020
@jellodiil jellodiil reopened this Feb 22, 2020
v1.0 automation moved this from Done to In progress Feb 22, 2020
@jellodiil
Copy link
Contributor Author

jellodiil commented Feb 22, 2020

Still happens.

Seems to be more of an issue when there are many Completed items.
(like when logged in as the professional subscriber..)

@sammyd sammyd moved this from In progress to To do in v1.0 Feb 22, 2020
@sammyd sammyd moved this from To do to In progress in v1.0 Feb 22, 2020
@sammyd sammyd moved this from In progress to Ready for Review in v1.0 Feb 22, 2020
@sammyd
Copy link
Collaborator

sammyd commented Feb 22, 2020

I think that this is caused by the problem in the backend—unchecking an item doesn't update the collection on the server. I'm gonna go with that for now, and try and fix the server soon.

@sammyd sammyd moved this from Ready for Review to Out for Review in v1.0 Feb 23, 2020
@jellodiil
Copy link
Contributor Author

I think I've merged this one in my head with #301

Don't recall how this is different......

@sammyd
Copy link
Collaborator

sammyd commented Feb 25, 2020

I think it'll be fixed with #371. I'll get you to take another look once I finally get it deployed.

@sammyd sammyd moved this from Out for Review to Ready for Review in v1.0 Feb 25, 2020
@sammyd sammyd added the backend An issue with the API label Feb 28, 2020
@sammyd sammyd moved this from Ready for Review to Out for Review in v1.0 Mar 6, 2020
@sammyd
Copy link
Collaborator

sammyd commented Mar 6, 2020

The backend has now been deployed, so this issue should be fixed. Please check and close.

@jellodiil
Copy link
Contributor Author

Rewatching a video in completed course does remove the completed label now.

v1.0 automation moved this from Out for Review to Done Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend An issue with the API bug Something isn't working
Projects
No open projects
v1.0
  
Done
Development

No branches or pull requests

2 participants