Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX feedback #541

Merged
merged 6 commits into from
Feb 9, 2022
Merged

UX feedback #541

merged 6 commits into from
Feb 9, 2022

Conversation

ashish10677
Copy link
Member

@ashish10677 ashish10677 commented Feb 1, 2022

Description

Fixes #536

Change Log

  • Removed --autoVote from README.
  • Renamed the stake command to addStake.
  • "Already committed, will not commit" moved to debug.
  • Change log.Debug to log.Info for Stake, Block, Epoch etc. information.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Tested with local hardhat
  • Tested with all the test cases.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Signed-off-by: Ashish Kumar Mishra <ashish10677@gmail.com>
Signed-off-by: Ashish Kumar Mishra <ashish10677@gmail.com>
Epoch, state, block information moved to log.Info

Signed-off-by: Ashish Kumar Mishra <ashish10677@gmail.com>
Signed-off-by: Ashish Kumar Mishra <ashish10677@gmail.com>
@ashish10677 ashish10677 linked an issue Feb 1, 2022 that may be closed by this pull request
4 tasks
Copy link
Contributor

@SkandaBhat SkandaBhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a short changelog in the PR description.

@ashish10677
Copy link
Member Author

Please add a short changelog in the PR description.

Done @SkandaBhat

@ashish10677 ashish10677 changed the base branch from develop to main February 4, 2022 06:58
@SkandaBhat
Copy link
Contributor

@adi44 please update the docs for this accordingly.

@SkandaBhat SkandaBhat merged commit 31b78ab into razor-network:main Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback
3 participants