Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should throw errors if people try to use standard svg properties on icons like fill-rule, clip-rule #648

Closed
divyanshu013 opened this issue Aug 18, 2022 · 2 comments · Fixed by #658
Closed

We should throw errors if people try to use standard svg properties on icons like fill-rule, clip-rule #648

divyanshu013 opened this issue Aug 18, 2022 · 2 comments · Fixed by #658

Comments

@divyanshu013
Copy link
Contributor

I think these should be fillRule, clipRule (TS should ideally be warning these). Similarly at other places.

Originally posted by @divyanshu013 in #645 (comment)
@divyanshu013 divyanshu013 mentioned this issue Aug 18, 2022
Merged
@divyanshu013 divyanshu013 changed the title TypeScript should throw errors if people try to use standard svg properties on icons like fill-rule, clip-rule We should throw errors if people try to use standard svg properties on icons like fill-rule, clip-rule Aug 18, 2022
@divyanshu013
Copy link
Contributor Author

Looks like this can't be done with TS, might have to add some tests - microsoft/TypeScript#32447

@anuraghazra anuraghazra mentioned this issue Aug 23, 2022
Merged
@divyanshu013
Copy link
Contributor Author

Looks like this can't be done with TS, might have to add some tests - microsoft/TypeScript#32447

I was wrong, forgot we've @anuraghazra 😛 :godmode:

@anuraghazra anuraghazra mentioned this issue Sep 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: prevented dashed props in svg path razorpay/blade
1 participant
@divyanshu013