-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Icons): add new icons #645
Conversation
add new icons
🦋 Changeset detectedLatest commit: fc70825 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add the changeset |
@@ -0,0 +1,20 @@ | |||
import { Svg, Path } from '../_Svg'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is an issue with Home icon lets not add it here? Otherwise this PR will remain blocked
@@ -0,0 +1,20 @@ | |||
import { Svg, Path } from '../_Svg'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved now
fill-rule="evenodd" | ||
clip-rule="evenodd" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these should be fillRule
, clipRule
(TS should ideally be warning these). Similarly at other places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This resolved the issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created #648 to track this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
"@razorpay/blade": patch | ||
--- | ||
|
||
feat(Icons): add new icons |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feat(Icons): add new icons | |
feat(Icons): add new icons | |
- ArrowDownIcon | |
- ArrowRightIcon | |
- ArrowUpIcon | |
- ArrowUpRightIcon | |
- HomeIcon | |
- SearchIcon |
Add new icons