Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): selection toggle for multiselect table #2076

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

amandal97
Copy link
Contributor

@amandal97 amandal97 commented Mar 12, 2024

Description

For a Multiselect Table Component, selection does not work if we click on the checkbox. However, it works if we click on the row itself. This PR is a short term solution to fix the problem.

Provided the issue link below for more details.

Changes

Stop event propagation while clicking on the multiselect checkbox

Additional Information

#1978

Component Checklist

  • Update Component Status Page
  • Perform Manual Testing in Other Browsers
  • Add KitchenSink Story
  • Add Interaction Tests (if applicable)
  • Add changeset

Copy link

changeset-bot bot commented Mar 12, 2024

⚠️ No Changeset found

Latest commit: 045ef1e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

✅ PR title follows Conventional Commits specification.

@rzpcibot
Copy link
Collaborator

Bundle Size Report

Updated Components
Status Component Base Size (kb) Current Size (kb) Diff
Table, TableHeader, TableHeaderCell, TableHeaderRow, TableBody, TableCell, TableRow, TableFooter, TableFooterCell, TableFooterRow, TablePagination, TableToolbar, TableToolbarActions 50.321 50.337 +0.016 KB

Generated by 🚫 dangerJS against 045ef1e

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 045ef1e:

Sandbox Source
razorpay/blade: basic Configuration

Copy link
Member

@saurabhdaware saurabhdaware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add changeset?

@saurabhdaware
Copy link
Member

Oh I am guessing we dont need this if we go with #2077

@chaitanyadeorukhkar chaitanyadeorukhkar merged commit 15a0551 into master Mar 28, 2024
17 checks passed
@chaitanyadeorukhkar chaitanyadeorukhkar deleted the fix/table-multi-select branch March 28, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants