Add error handling to save function (hashicorp-forge#211)

razorpay · Jun 14, 2023 · fcc1ac3 · fcc1ac3
1 parent 4149a39
commit fcc1ac3
Showing 1 changed file with 18 additions and 15 deletions.
diff --git a/web/app/components/document/sidebar.ts b/web/app/components/document/sidebar.ts
@@ -216,16 +216,20 @@ export default class DocumentSidebarComponent extends Component<DocumentSidebarC
 
   @action maybeShowFlashError(error: Error, title: string) {
     if (!this.modalIsActive) {
-      this.flashMessages.add({
-        title,
-        message: error.message,
-        type: "critical",
-        timeout: 6000,
-        extendedTimeout: 1000,
-      });
+      this.showFlashError(error, title);
     }
   }
 
+  showFlashError(error: Error, title: string) {
+    this.flashMessages.add({
+      title,
+      message: error.message,
+      type: "critical",
+      timeout: 6000,
+      extendedTimeout: 1000,
+    });
+  }
+
   @action showFlashSuccess(title: string, message: string) {
     this.flashMessages.add({
       message,
@@ -236,13 +240,11 @@ export default class DocumentSidebarComponent extends Component<DocumentSidebarC
     });
   }
 
-  updateProduct = restartableTask(
-    async (product: string) => {
-      this.product = product;
-      await this.save.perform("product", this.product);
-      // productAbbreviation is computed by the back end
-    }
-  );
+  updateProduct = restartableTask(async (product: string) => {
+    this.product = product;
+    await this.save.perform("product", this.product);
+    // productAbbreviation is computed by the back end
+  });
 
   save = task(async (field: string, val: string | HermesUser[]) => {
     if (field && val) {
@@ -261,7 +263,8 @@ export default class DocumentSidebarComponent extends Component<DocumentSidebarC
       } catch (err) {
         // revert field value on failure
         (this as any)[field] = val;
-        console.error(err);
+
+        this.showFlashError(err as Error, "Unable to save document");
       }
     }
   });