Merge pull request #337 from razorpay/release/2.0.13

[release] 2.0.13

.github/workflows/scraper.yml

@@ -1,4 +1,5 @@
 on:
+  push:
   workflow_dispatch:
     inputs:
       release:
@@ -38,7 +39,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: shivammathur/setup-php@v2
         with:
-          php-version: 8.0
+          php-version: 8.1
           tools: phpunit, composer
       - run: composer install --no-interaction
       - name: Download artifacts
@@ -49,7 +50,7 @@ jobs:
       - name: Extract artifact
         run: gunzip by-bank.tar.gz
         working-directory: scraper/scripts/data
-      - run: phpunit -d memory_limit=-1
+      - run: phpunit --migrate-configuration -d memory_limit=-1
         env:
           RUN_DATASET_TESTS: true
   release-notes:
@@ -59,7 +60,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: shivammathur/setup-php@v2
         with:
-          php-version: 8.0
+          php-version: 8.1
       - name: Download artifacts
         uses: actions/download-artifact@v3
         with:

.github/workflows/tests.yml

@@ -28,7 +28,7 @@ jobs:
           php-version: ${{matrix.php}}
           tools: phpunit, composer
       - run: composer install --no-interaction
-      - run: phpunit -d memory_limit=-1
+      - run: phpunit --migrate-configuration -d memory_limit=-1
   ruby:
     strategy:
       matrix:

CHANGELOG.md

@@ -5,6 +5,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [UNRELEASED][unreleased]
 
+## [2.0.13][2.0.13]
+### Changed
+- Metadata updates
+
 ## [2.0.12][2.0.12]
 ### Changed
 - Metadata updates

README.md

@@ -170,7 +170,7 @@ $res = $client->lookupIFSC('KKBK0000261');
 
 echo $res->bank; // 'KOTAK MAHINDRA BANK LIMITED'
 echo $res->branch; // 'GURGAON'
-echo $res->address; // 'JMD REGENT SQUARE,MEHRAULI GURGAON ROAD,OPPOSITE BRISTOL HOTEL,'
+echo $res->address; // 'KOTAK MAHINDRA BANK LTD. UNIT NO. 8&9, SEWA CORPORATE PARK, MG ROAD, REVENUE STATE OF SARHAUL TEHSIL, DISTT,- GURGAON- 122001'
 echo $res->contact; // '4131000'
 echo $res->city; // 'GURGAON'
 echo $res->district; // 'GURGAON'
@@ -287,7 +287,7 @@ code.bank
 code.branch
 # => "GURGAON"
 code.address
-# => "JMD REGENT SQUARE,MEHRAULI GURGAON ROAD,OPPOSITE BRISTOL HOTEL,"
+# => "KOTAK MAHINDRA BANK LTD. UNIT NO. 8&9, SEWA CORPORATE PARK, MG ROAD, REVENUE STATE OF SARHAUL TEHSIL, DISTT,- GURGAON- 122001"
 code.contact
 # => "4131000"
 code.city
@@ -396,7 +396,7 @@ func main() {
 	(*ifsc.IFSCResponse)({
 	 Bank	  :  "Kotak Mahindra Bank",
 	 Branch	  :  "GURGAON",
-	 Address  :  "JMD REGENT SQUARE,MEHRAULI GURGAON ROAD,OPPOSITE BRISTOL HOTEL,",
+	 Address  :  "KOTAK MAHINDRA BANK LTD. UNIT NO. 8&9, SEWA CORPORATE PARK, MG ROAD, REVENUE STATE OF SARHAUL TEHSIL, DISTT,- GURGAON- 122001",
 	 Contact  :  "4131000",
 	 City	  :  "GURGAON",
 	 District :  "GURGAON",

ifsc.gemspec

@@ -3,7 +3,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |s|
   s.name        = 'ifsc'
-  s.version     = '2.0.12'
+  s.version     = '2.0.13'
   s.date        = '2022-10-28'
   s.summary     = 'IFSC code database to help you validate IFSC codes'
   s.description = 'A simple gem by @razorpay to help you validate your IFSC codes. IFSC codes are bank codes within India'

package.json

@@ -1,6 +1,6 @@
 {
   "name": "ifsc",
-  "version": "2.0.12",
+  "version": "2.0.13",
   "description": "This is part of the IFSC toolset released by Razorpay. You can find more details about the entire release at [ifsc.razorpay.com](https://ifsc.razorpay.com). Includes only a validation library as of now.",
   "main": "src/node/index.js",
   "directories": {

scraper/scripts/bootstrap.sh

@@ -2,7 +2,7 @@
 set -euo pipefail
 IFS=$'\n\t'
 
-mkdir --parents data/by-bank sheets
+mkdir -p data/by-bank sheets
 USER_AGENT="Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/97.0.4692.99 Safari/537.36"
 
 # Downloads are disabled for now, since NPCI setup Bot protection at their end.

scraper/scripts/methods.rb

@@ -208,7 +208,7 @@ def parse_csv(files, banks, additional_attributes = {})
       end
 
       # The address somehow contains a pipe-delimited value for other columns
-      if row['ADDRESS'].count('|') > 2
+      if row['ADDRESS'] != nil and row['ADDRESS'].count('|') > 2
         fix_pipe_delimited_address!(row)
       end
 

tests/fixture/KKBK0000261.json

@@ -1 +1 @@
-{"MICR":"110485003","BRANCH":"GURGAON","ADDRESS":"JMD REGENT SQUARE,MEHRAULI GURGAON ROAD,OPPOSITE BRISTOL HOTEL,","STATE":"HARYANA","CONTACT":"4131000","UPI":true,"RTGS":true,"CITY":"GURGAON","CENTRE":"GURGAON","DISTRICT":"GURGAON","NEFT":true,"IMPS":true,"SWIFT":"","ISO3166":"IN-HR","BANK":"Kotak Mahindra Bank","BANKCODE":"KKBK","IFSC":"KKBK0000261"}
+{"MICR":"110485003","BRANCH":"GURGAON","ADDRESS":"KOTAK MAHINDRA BANK LTD. UNIT NO. 8&9, SEWA CORPORATE PARK, MG ROAD, REVENUE STATE OF SARHAUL TEHSIL, DISTT,- GURGAON- 122001","STATE":"HARYANA","CONTACT":"4131000","UPI":true,"RTGS":true,"CITY":"GURGAON","CENTRE":"GURGAON","DISTRICT":"GURGAON","NEFT":true,"IMPS":true,"SWIFT":"","ISO3166":"IN-HR","BANK":"Kotak Mahindra Bank","BANKCODE":"KKBK","IFSC":"KKBK0000261"}

tests/fixture/exvcr/valid_ifsc.json

@@ -10,7 +10,7 @@
     },
     "response": {
       "binary": false,
-      "body": "{\"BRANCH\":\"GURGAON\",\"ADDRESS\":\"JMD REGENT SQUARE,MEHRAULI GURGAON ROAD,OPPOSITE BRISTOL HOTEL,\",\"CONTACT\":\"4131000\",\"CITY\":\"GURGAON\",\"DISTRICT\":\"GURGAON\",\"STATE\":\"HARYANA\",\"RTGS\":true,\"BANK\":\"Kotak Mahindra Bank\",\"BANKCODE\":\"KKBK\",\"IFSC\":\"KKBK0000261\"}",
+      "body": "{\"BRANCH\":\"GURGAON\",\"ADDRESS\":\"KOTAK MAHINDRA BANK LTD. UNIT NO. 8&9, SEWA CORPORATE PARK, MG ROAD, REVENUE STATE OF SARHAUL TEHSIL, DISTT,- GURGAON- 122001\",\"CONTACT\":\"4131000\",\"CITY\":\"GURGAON\",\"DISTRICT\":\"GURGAON\",\"STATE\":\"HARYANA\",\"RTGS\":true,\"BANK\":\"Kotak Mahindra Bank\",\"BANKCODE\":\"KKBK\",\"IFSC\":\"KKBK0000261\"}",
       "headers": {
         "Access-Control-Allow-Origin": "*",
         "Content-Security-Policy": "default-src 'self' razorpay.com; font-src 'self' fonts.gstatic.com; img-src cdn.razorpay.com razorpay.com; object-src 'none'; script-src 'none'; style-src 'self' 'unsafe-inline' fonts.googleapis.com",

tests/node/client_test.js

@@ -7,7 +7,7 @@ const expected = require('../fixture/HDFC0CAGSBK')
 ifsc
   .fetchDetails('KKBK0000261')
   .then(function(res) {
-    assert.equal('JMD REGENT SQUARE,MEHRAULI GURGAON ROAD,OPPOSITE BRISTOL HOTEL,',res['ADDRESS'])
+    assert.equal('KOTAK MAHINDRA BANK LTD. UNIT NO. 8&9, SEWA CORPORATE PARK, MG ROAD, REVENUE STATE OF SARHAUL TEHSIL, DISTT,- GURGAON- 122001',res['ADDRESS'])
     assert.equal('Kotak Mahindra Bank',res['BANK'])
     assert.equal('KKBK',res['BANKCODE'])
     assert.equal('GURGAON',res['BRANCH'])