Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issues with signature verification #110

Closed
wants to merge 1 commit into from

Conversation

saadmk11
Copy link
Contributor

@saadmk11 saadmk11 commented Sep 19, 2020

closes #106

The verify_signature function should return True or False it should not return a True or Exception

this PR removes the confusion with the verify_signature

By making it only boolean it will make it easy for users to check if the verification succeeded or failed with just a condition.

@saadmk11 saadmk11 closed this Jan 13, 2023
@saadmk11 saadmk11 deleted the verify-sig branch January 13, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Behaviour Not Clear
1 participant