Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift wrapper #45

Merged
merged 4 commits into from
Jan 17, 2018
Merged

Swift wrapper #45

merged 4 commits into from
Jan 17, 2018

Conversation

nitinbizsingh
Copy link

No description provided.

#import <Razorpay/Razorpay.h>
#import <Razorpay/RazorpayPaymentCompletionProtocolWithData.h>
Copy link
Author

@nitinbizsingh nitinbizsingh Dec 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AbhinavArora95 This is the change in the react native wrapper that I was talking about. If people try to run the new framework with the wrapper on npm right now they will get a compile error because of missing ExternalWalletSelectionProtocol and RazorpayPaymentCompletionProtocolWithData Let's push an update to npm once you are back.

Also I think we can make the integration easier for merchants. What are you thoughts on these:

  1. Let's make our documentation clearer explaining why we are not shipping the framework with the wrapper and redirecting them to the correct page for downloading the different versions.

  2. The package.json for the example app should point to npm and not the local copy as it does right now given that the idea of this is to show the merchants how their package.json should look like and not development of the wrapper itself.

  3. All the additional steps that we have mentioned other than maybe adding the framework to the project can be converted to a single script. Let's do that and the readme can just show how to execute the script.

  4. Some of the additional steps like making the changes to the AppDelegate file seems to be not needed anymore. I was able to run my sample project without those changes. Can we remove those?

@AbhinavArora95 AbhinavArora95 merged commit a5976f7 into master Jan 17, 2018
@hariramsvnit hariramsvnit deleted the swift_wrapper branch August 1, 2018 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants