Feature: Add class that allows configuration of a bond or bridge interface with no ipaddress #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 22, 2015 09:28
a "null" or un-ipaddressed interface.
|
Would it be possible to add some rspec tests for this? |
|
@davidgibbons : bump |
|
Fixed in #58. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't want to alter the ip checking behavior of the static classes but I'm needing interfaces with no set addresses for a complex bonding/bridge setup. It would have also been possible to check/set ipaddress to an empty string in the static classes and allow that but the logic you have in place already seems specific in its purpose, it's also calling it specifically a "static" class so I figured a matching "null" class might be the most consistent solution.