Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for async_std types? #24

Closed
gabrik opened this issue Sep 16, 2021 · 3 comments
Closed

Support for async_std types? #24

gabrik opened this issue Sep 16, 2021 · 3 comments

Comments

@gabrik
Copy link

gabrik commented Sep 16, 2021

First, thank you for keeping alive this very useful crate.

I was wondering if there is any plan to support async_std types.
Especially in the MmapOptions.

As mentioned in the doc https://docs.rs/async-std/1.10.0/async_std/fs/index.html those types are just the async version of the ones in the standard library, so I guess it should be quite easy.

Thanks

@RazrFalcon
Copy link
Owner

Only if someone will send a patch.

@gabrik
Copy link
Author

gabrik commented Sep 16, 2021

Sounds reasonable, do you would like to have the async_std support as a feature?
I think it would be better and in this way only people using async_std would activate it.

gabrik added a commit to gabrik/memmap2-rs that referenced this issue Sep 16, 2021
Signed-off-by: gabrik <gabriele.baldoni@gmail.com>
@RazrFalcon
Copy link
Owner

Fixed by #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants