Skip to content

Commit

Permalink
msm_fb: display: initialize dmap_comp before wait4dmap
Browse files Browse the repository at this point in the history
blt_wait flag will be set when both two writeback buffers
are used. In this case, kickoff can not be proceeded until
next dmap_done to release writeback buffer. This patch
initialize dmap_comp before wait4dmap to make sure
wait_for_completion is enforced.

CRs-fixed: 448168
Change-Id: I64f2ad599b18f9d8b346c41a55829c564fcced0b
Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org>

Conflicts:

	drivers/video/msm/mdp4_overlay_dsi_cmd.c
  • Loading branch information
Kuogee Hsieh authored and nadlabak committed Jun 28, 2013
1 parent f95be7a commit 12492f9
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/video/msm/mdp4_overlay_dsi_cmd.c
Expand Up @@ -328,9 +328,11 @@ int mdp4_dsi_cmd_pipe_commit(int cndx, int wait)
spin_lock_irqsave(&vctrl->spin_lock, flags);
if (pipe->ov_blt_addr) {
/* Blt */
if (vctrl->blt_wait)
if (vctrl->blt_wait) {
INIT_COMPLETION(vctrl->dmap_comp);
need_dmap_wait = 1;
else if (vctrl->ov_koff != vctrl->ov_done) {
}
if (vctrl->ov_koff != vctrl->ov_done) {
INIT_COMPLETION(vctrl->ov_comp);
need_ov_wait = 1;
}
Expand Down

1 comment on commit 12492f9

@nadlabak
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes another recently introduced display issue in charge_only_mode for cmd panel devices.

Please sign in to comment.